search

Stvad / CrowdAnki

Plugin for Anki SRS designed to facilitate cooperation on creation of notes and decks.
MIT License
520 stars 44 forks source link

Adapt to 2.1.50+ backup mechanism #167

Closed aplaice closed 2 years ago

aplaice commented 2 years ago

Fix #166.

It's no longer necessary for the collection to be closed before a backup, and AFAICT a closed collection can't even be backed up.

See PR 1728 in Anki itself. (Not linking directly to avoid spam for DAE etc.)

This breaks compatibility with 2.1.49-.

Also: silence most verbose deprecation warnings (in 2.1.50+)

I've left the Qt warnings alone for now, since the behaviour varies between Qt5 and Qt6.

AFAICT importing, exporting and snapshotting all work in 2.1.50 and 2.1.52 both with Qt5 and Qt6 (using the default Qt5 compatibility shims).

boydkelly commented 2 years ago

Fix #166.

I've left the Qt warnings alone for now, since the behaviour varies between Qt5 and Qt6.

AFAICT importing, exporting and snapshotting all work in 2.1.50 and 2.1.52 both with Qt5 and Qt6 (using the default Qt5 compatibility shims)al.

Tested also in 2.1.51 qt5 and 2.1.53 qt6 both imports successful.

Thank you very much!

aplaice commented 2 years ago

Thanks very much for testing (especially 2.1.53)! (I'll try to check if there are any other regressions there, soon-ish.)