search

Stvad / CrowdAnki

Plugin for Anki SRS designed to facilitate cooperation on creation of notes and decks.
MIT License
536 stars 43 forks source link

Incorrect JSON when exporting a deck containing cloned note types #35

Open tfiwm opened 5 years ago

tfiwm commented 5 years ago

Details:

Say there are two note types type1 and type2 and type1 was cloned (anki feature while creating new note types) to create type2. Now create a deck ABC which has notes based on the two note type1 and type2. If you export deck ABC using CrowdANKI, the resulting JSON representation will have only one note type or one NoteModel. As a result all the notes in the JSON which were exported from deck ABC will have the crowdanki_uuid of this NoteModel as the note_model_uuid. Importing this JSON representation to Anki will eventually result in a crash. For whatever reason, crowdanki is assuming a cloned note type and its parent to be identical (?)

Anki Version 2.1.5 Qt 5.9.2 PyQt 5.9 Platform: Windows 10

Stvad commented 5 years ago

My immediate guess would be that note_model_uuid is copied when the note type is cloned, so CrowdAnki does not generate new uuid for it.
If it's the case, it'd be a bit tricky to fix. I think we'd need to check for duplicates at the export time or something like that.

magicprinc commented 5 years ago

I have the same problem. The cloned note type replaces original note type in CrowdAnki JSON. It's a BIG problem! The deck could be easily corrupted (actually I did it).

johnlawrenceaspden commented 5 years ago

Me too, causes all sorts of trouble...