#46 git import - Githubissues

evolverine commented 4 years ago

A few notes:

you can ignore the first four commits. I made them when I wasn't yet aware that Dulwich was already a dependency of this project, and I was including GitPython. This is reverted in d502c48
commit e72ef09 introduces a change in the directory structure that the repository is created in: instead of "CrowdAnki/repo_name/git" it uses "CrowdAnki/user_name/repo_name/". This is reverted in the last commits, but I do want to ask you about it, because I think it's much better to use the github username in the path, to avoid naming conflicts. What do you think, will this also impact on other parts of the add-on?
the feature we have now is that we clone a repository instead of downloading the zip (and pull if the repository exists). I have not yet implemented the remote addition, but I'm happy to do it next if the direction seems good.

Also, two questions:

Instead of the Anki profile directory, shouldn't we now use the directory in the plugin settings to clone the repository?
For everyone but the repository maintainers the initially-cloned repository will have to be converted into a fork if they want to contribute any changes. Maybe we can automate that within this add-on using hub?

Stvad commented 4 years ago

Integrating with github to create forks/etc - In general seems like a good idea for simplifying the flow, we should discuss how interaction would look like before going there though. And should be a separate CR.

Also using the actual cli tool really makes life harder distribution-wise, I imagine there is python lib out there for talking to Github API, which would be a better choice

evolverine commented 4 years ago

agreed, a python library would be great for that.

katrinleinweber commented 4 years ago

[…] python lib […] for talking to Github API

[…] would be great for that.

Have you found developer.github.com/v3/libraries? It has a Python section, of which PyGithub seems to be quite API-complete :-)

evolverine commented 4 years ago

Thanks @katrinleinweber for researching the libraries. Can't wait to have this implemented. For now, let's finalize this pull request.

evolverine commented 4 years ago

@Stvad did you have a chance to take a look at the commits? Thanks.

Stvad commented 4 years ago

@evolverine I apologize for the delay, I thought I did, but I missed the latest batch. I'll take a look in the next few days!

Stvad commented 4 years ago

Looks good to me besides the small nit that I've noted!

evolverine commented 4 years ago

great. And check out the last commit as well, where I made improvements in the way the repository URL is parsed. If that looks good, on my side it's all done (otherwise let me know if any changes are in order).

evolverine commented 4 years ago

Heya, did you have a chance to look at the latest changes? Thanks!

Stvad commented 4 years ago

Hey, thank you for a reminder, been a bit swamped recently =. Will take a look today

Stvad commented 4 years ago

Looks good! Thank you for working on this! Sorry for a slow turn-around

evolverine commented 4 years ago

Yaay! Calls for a celebration 😃️🎉️

Stvad / CrowdAnki

#46 git import #78