search

Stwissel / node-red-contrib-salesforce

A set of Node-RED nodes to interact with Salesforce and Force.com
MIT License
10 stars 17 forks source link

query variable in sosl and soql nodes has wrong scope #13

Closed dwindibank closed 6 years ago

dwindibank commented 6 years ago

The query variable (var query ='') in the soql and sosl nodes have the wrong scope. This results in the variable being reused ... i.e. multiple message's overwriting the value of the variable (via each messages' msg.query value).

I think this may have been the root cause on jeffdonthemic/node-red-contrib-salesforce#8 and jeffdonthemic/node-red-contrib-salesforce#2

dwindibank commented 6 years ago

I created a pull request for this: #14

Stwissel commented 6 years ago

Thx for that. Slipped my debugging. Merged in

Stwissel commented 6 years ago

Btw.: need to bump version in package.json, so build process can automatically publish it

dwindibank commented 6 years ago

Awesome. Thanks!

I'll remember about the version bump for next time I submit a pull request. Thanks, again.