Gruntfile change breaks script on Firefox

StylishThemes / GitHub-Dark-Script

Archived - Please use https://github.com/StylishThemes/GitHub-Dark directly

https://greasyfork.org/en/scripts/15562

MIT License

550 stars 51 forks source link

Gruntfile change breaks script on Firefox #62

Closed DarthParametric closed 5 years ago

DarthParametric commented 5 years ago

The 53d90e2 commit, changing line 481 from

.replace(/\s+\/\* grunt build - remove to end of file(.*(\n|\r))+\}$/m, "");

.replace(/\s+\/\* grunt build - remove start \*\/.*\s+\/\* grunt build - remove end \*\/$/sm, "");

results in the script no longer working on Firefox 65.0.2 on Windows using either Tampermonkey or Violentmonkey. Reverting to an older version or editing the line manually restores functionality.

darcien commented 5 years ago

Yeah, the s flag is not supported yet by Firefox. And it's unassigned on bugzilla [0].

Ref: [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1361856

Mottie commented 5 years ago

Hi @DarthParametric & @darcien!

Thanks for letting us know. It should be fixed now.

DarthParametric commented 5 years ago

~~Nope, still broken.~~

Mottie commented 5 years ago

Hmm, well maybe someone else can take a look. I've got to run 😞

DarthParametric commented 5 years ago

Sorry, my mistake., Disregard. It updated to the previous commit. Had to force a new manual update to get it to 2.5.2. It is working now.