Code previews for repos do not indicate its private status

StylishThemes / GitHub-Dark

:octocat: Dark GitHub style

https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css

BSD 2-Clause "Simplified" License

9.66k stars 654 forks source link

Code previews for repos do not indicate its private status #1030

Closed haykam821 closed 4 years ago

haykam821 commented 4 years ago

Normally, previews of code from a private repository show with a yellow accent in search results. However, with GitHub Dark, this does not happen.

Browser: Chromium 78
Operating System: macOS Mojave
Link to page with the issue: https://github.com/search?q=private+repo&type=Code
Screenshot: The following is code from a private repository in both GitHub Dark and GitHub Dark-less environments:

the-j0k3r commented 4 years ago

This is intentional, its still highlighted but hard to see

@xt0rted added this, I would prefer more contrast also.

haykam821 commented 4 years ago

@the-j0k3r I don't see any styling that affects the relevant code-list-item-private class here.

the-j0k3r commented 4 years ago

Oh I misunderstood. Yea Ill look into it when I have time. Just taken with other projects also, so bare with us.

I can tell that without GitHub Dark enabled there is also no styling https://github.com/search?q=private+repo and disable GitHub Dark

Capture

There no highlighting there either, so Im unsure how to fake support this.

haykam821 commented 4 years ago

@the-j0k3r I've clarified the link so it shows the 'code' tab. Those previews have a yellow tint when the repository is private.

xt0rted commented 4 years ago

I'm working on a fix for this.

xt0rted commented 4 years ago

Before	After

Regarding the highlighted text, I've been playing around with using the highlight color from my syntax theme. I use Monokai which uses #a6e22e and looks like this:

I'm not sure what this is like with the other themes, but it could be an option to make this a bit easier to see.