StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.67k stars 654 forks source link

Made a GitHub Education Dark Theme #1062

Closed TheBillyIsMe closed 4 years ago

TheBillyIsMe commented 4 years ago

Hello 😄, As a big fan of this project, I figured why not go ahead and extend the concept to GitHub Education. I've created a GitHub Education Dark Theme and as the StylishThemes organization is the sole maintainer of GitHub-related Dark Stylus themes, I was wondering if the team here would be interested in having the repository transferred to the organization.

Thanks for your time, TheBillyIsMe.

https://github.com/TheBillyIsMe/GitHub-Education-Dark

Mottie commented 4 years ago

Hi @TheBillyIsMe!

We are really only able to maintain styles that we tend to use a lot. If you're willing to continue keeping this style up-to-date, we could move it over to this organization and make you a maintainer. We may not be able, or have time, to help you maintain it. So, the only real benefit would be more exposure for your style.

TheBillyIsMe commented 4 years ago

Hi @TheBillyIsMe!

We are really only able to maintain styles that we tend to use a lot. If you're willing to continue keeping this style up-to-date, we could move it over to this organization and make you a maintainer. We may not be able, or have time, to help you maintain it. So, the only real benefit would be more exposure for your style.

I'd definitely be able to do that, that would be great! How would we go about doing so?

the-j0k3r commented 4 years ago

Well, heres the rub, I dont mind either but, why do we need a whole new theme?

from basic testing, adding education to GitHub Dark is pretty much little more than adding education to the regexp

-@-moz-document regexp("^https?://((gist|guides|help|lab|launch-editor|raw|resources|status|developer|support)\\.)?github\\.com/((?!generated_pages/preview).)*$"), domain("githubusercontent.com"), domain("graphql-explorer.githubapp.com"), domain("www.githubstatus.com") {
+@-moz-document regexp("^https?://((education|gist|guides|help|lab|launch-editor|raw|resources|status|developer|support)\\.)?github\\.com/((?!generated_pages/preview).)*$"), domain("githubusercontent.com"), domain("graphql-explorer.githubapp.com"), domain("www.githubstatus.com") {

Then maybe a couple of text colors (text color for GitHub Education) and were done, so is it really necessary all that extra work and a whole separate style for a single subdomain?

I recon I can add this support in 1 minute.

Screenshot_2020-02-13 Discounted and free plans are available for educational use

As you can see its just one text bit. Ill add that in a sec.