search

StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.67k stars 655 forks source link

Twilight is overriding custom theme again #1077

Closed mallowigi closed 4 years ago

mallowigi commented 4 years ago

It happened pretty recently, somehow there are two themes loaded in the webpage, the selected one plus Twilight. Apparently the remove start wasn't executed

the-j0k3r commented 4 years ago

What webpage? Thers not much to do with the information provided.

mallowigi commented 4 years ago

Ok let me rephrase it:

Since very recently, the custom theme in the source code (CodeMirror) has become the Twilight theme, independently of the theme selected (currently One Dark). I've inspected the style tag that was injected in the webpage (Github) and I see that the section that was usually removed by the grunt task, encapsulated by remove start and remove end comments, is currently there, which is causing the Twilight theme to override the theme.

the-j0k3r commented 4 years ago

Again what web page? In order to fix I must see the issue. Youre exact setup, OS, browser etc. You just overwrote the issue template and provided no actionable info.

I understand the issue the explanation covers it, but I cant see what you see.

the-j0k3r commented 4 years ago

I cant duplicate any issues with overriding syntax themes, Are you sure you are using this GitHub Dark + stylus and not some chrome extension?

Also disable any other styles that maybe interfering.

Provide screenshots, provide OS/Browser info and steps to duplicate your issue,

mallowigi commented 4 years ago

I'm not using Stylus but the TamperMonkey script.

I've reinstalled from scratch to make sure

Here's my settings window. I've changed the codeMirror theme to Github Dark

window

But here's the code: Twilight theme

code

Thank you for your patience.

the-j0k3r commented 4 years ago

Please use stylus + Github Dark usercss instead. That script is buggy and none is really maintaining it or fixing the big issues.

I'm not using Stylus but the TamperMonkey script.

Also for future ref the bug reports for that go https://github.com/StylishThemes/GitHub-Dark-Script not in this repo.

Thanks.

mallowigi commented 4 years ago

Ok I’ll post there but I wish someone will take care of it, I prefer using the script as it is easier to change the accent color or the themes.

In the worst case scenario I’ll fix it myself like I did with another script that I use every day.

the-j0k3r commented 4 years ago

I prefer using the script as it is easier to change the accent color or the themes.

Its really easy with GitHub Dark + Stylus

generic

Also The script cant handle multiple @moz-document rules so it will be broken by default.

Overall your experience with GitHub Dark + Stylus is MUCH improved because you dont get white flashes on page load

Also GitHub Dark + Stylus supports https://github.com/StylishThemes/GitHub-Dark#additional-userstyles Something that the script doesnt.

the-j0k3r commented 4 years ago

Be advised that grunt was removed from this style, Github Dark script loads this style. so IDK.

mallowigi commented 4 years ago

Alright, you can close ths issue