StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.65k stars 653 forks source link

Orange background for one element in the code view #1156

Open LingMan opened 4 years ago

LingMan commented 4 years ago

The word proc has an orange background when themed.

the-j0k3r commented 4 years ago

this is the .pl-bu

.pl-bu, .pl-ii, .pl-ii .pl-cce {
    background-color: #df5000 !important;
    color: #fff !important;
}

So what exactly is the problem? All our syntax themes have this and also look at https://github.com/StylishThemes/GitHub-Dark/issues/1052, so Im unsure if this is actually an issue.

the-j0k3r commented 4 years ago

mm I dont see this bg in default codemirror themes, but this isnt critical issue and I rather fix it when the new syntax themes are done.

When you edit the file over web you see twilight theme isnt respected either mostly everything is orange re: #1052 those issues also need to be solved first.

Capture

So, bare with me while I redo all our syntax themes into a new format. NO ETA yet,

LingMan commented 4 years ago

The problem is that this orange block sticks out like a sore thumb in the dark theme while there's just the default while background with the default Github theme. Judging by your second post, I take it you noticed that as well.

So, bare with me while I redo all our syntax themes into a new format. NO ETA yet,

Not in a hurry. Just wanted to make sure you're aware of the problem

the-j0k3r commented 4 years ago

Please re-read my last reply, its not important to fix this now when theres so many upstream issues like #1052 to solve before this is even fixed.

Again Im re-writing all the syntax themes into a dif format which will cleanup all these issues, that job is more important than this.

I apologize for annoyance, if you like create a new local theme like


/* ==UserStyle==
@name           github.com - 6/28/2020, 8:07:48 PM
@namespace      github.com/openstyles/stylus
@version        1.0.0
@description    A new userstyle
@author         Me
==/UserStyle== */

@-moz-document domain("github.com") {
  .pl-bu {
      background-color: initial !important;
      color: #fff !important;
  }
}

that should take care of that issuee until eventually uptream fixes the issues adn we have new syntax themes.

Nothing for this year though, Im busy.

LingMan commented 4 years ago

Like I said: Not in a hurry. Just wanted to make sure you're aware of the problem.

the-j0k3r commented 4 years ago

In meanwhile you have a temp solution above.