StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.65k stars 653 forks source link

Documentation / Wiki update #1167

Open the-j0k3r opened 4 years ago

the-j0k3r commented 4 years ago

Our contributing.md and general readmes, is now mostly obsolete. ORG wide issue in 99% of repos not just this style.

related to https://github.com/StylishThemes/GitHub-Dark/issues/1166#issuecomment-653840137

the-j0k3r commented 4 years ago

Some updates in https://github.com/StylishThemes/GitHub-Dark/commit/afc7f27fb9a00a08615d3c0f7af0b317a8977b5d and https://github.com/StylishThemes/GitHub-Dark/commit/0c4453f02eef89d97e2014377c0f5ec37f100227

This is still largely Not OK

Some of the un-edited entries need reformulating to make them beginner friendly. aka K.I.S.S

@xt0rted if you have time to cleanup lingo would be great. Else will have to wait indefinitely.

No checkboxes have been ticked in the list above, mainly cause, well, its still a large mess even if its less now its still not fine.

silverwind commented 4 years ago

Happy with any simplifications/clarification but I wouldn't bet on contributions, those have always been rather non-existant, probably because of the complexity which we can not really reduce easily.

the-j0k3r commented 4 years ago

Hence docs, clearly ppl need to know how this works. I dont think more contributors will multiply overnight, but without docs none knows how to contribute, what to edit etc.

In this case the generator, what to follow and do when contributing fixes via generator etc.

silverwind commented 4 years ago

I'm thinking about just nuking CONTRIBUTING.md, it's way too verbose and https://github.com/StylishThemes/GitHub-Dark#development is all needed info really.

the-j0k3r commented 4 years ago

far from it, well far from it

Theres no generator info, no way how it works no explanations of anything. No steps to follow for first timers, nothing.

, and you think its OK?

Ill agree contributingMD is mostly obsolete, and nuking it is not a bad idea, but at least include proper info. As is, thats not it.

the-j0k3r commented 4 years ago

We should include this also

These special mapping keys supported:

- `$border: value`: Any occurance of `value` in a `border` rule.
- `$background: value` Any occurance of `value` in a `background` rule.
- `$box-shadow: value` Any occurance of `value` in a `box-shadow` rule.
- `$color: value`: Any occurance of `value`.

and some info that tells ppl where to add/edit those values.

WE simply must document how the gen works, provide that info in a simple way and not making it hard to contribute.

the-j0k3r commented 4 years ago

Following https://github.com/StylishThemes/GitHub-Dark/commit/cad6a0f1487da33c44254713b6aa9da90f25550b Only the wiki and odds and ends needs TLC