Closed shrek-gabe-itch closed 4 years ago
Not able to duplicate disable all other styles, maybe even remove GHD and reinstall
Not able to duplicate disable all other styles, maybe even remove GHD and reinstall
disabling other styles and reinstalling doesn't help, other dark styles for github I've tried behave the same except one https://userstyles.org/styles/182032/github-one-dark-theme
disabling other styles and reinstalling doesn't help, other dark styles for github I've tried behave the same except one https://userstyles.org/styles/182032/github-one-dark-theme
I hope you're not installing GitHub Dark from userstyles website, if you are, remove it and install from https://github.com/StylishThemes/GitHub-Dark#installation
I hope you're not installing GitHub Dark from userstyles website, if you are, remove it and install from https://github.com/StylishThemes/GitHub-Dark#installation
this versions from github looks broken for me, I just gave an example of the theme with which everything looks fine
Sorry cannot duplicate, Here Stylus + GHD usercss + Firefox/Chrome on Windows works fine.
What extension are you using? Stylus? Stylish? Other?
If the answer is anything but Stylus, then this could explain your issues.
Must be something interferring, try a fresh browser profile.
Steps to reproduce in Firefox (on Linux):
Write new style
github-dark.user.css
or use the import
button under Mozilla FormatResult: Exactly as seen in the screenshot pf @shrek-gabe-itch. Why? Some placeholders do not get correctly resolved, e.g.:
-ghd-bg-custom: /*[[bg-custom]]*/;
--ghd-bg-img: /*[[bg-choice]]*/;
--ghd-bg-color: /*[[bg-color]]*/;
Workaround
install style
button @Gambloide the workaround is the correct way and official way to install this style, We dont suggest any other methods.
Also you need to ensure that when creating a new style in stylus Step 4, the usercss option is enabled.
if not, it may explain the issues with your main method I dont think stylus automatically detects a usercss style being pasted into a legacy CSS editor. It works just fine here FYI.
@tophf or @eight04 may know better how this works internally. Not sure if the usercss meta is parsed correctly otherwise.
This is the first time I see someone incorrectly pasting a usercss code into the legacy editor. Well, there are always lots of ways to shoot oneself in the leg but I agree we should show a confirmation and switch the editor accordingly or at least explain how to do it to the user. https://github.com/openstyles/stylus/issues/1080
As someone that comes from legacy extensions where this was the approach to "install" a style, I parsed the GitHub-Dark installation instructions as: (1) install extension; (2) create new style, paste css into editor, check and if required adjust scope, click apply.
1. Install Stylus for Firefox, Chrome, Opera or Cascadea for Safari.
2. Install github-dark.user.css.
I think https://github.com/openstyles/stylus/issues/1080 is a good idea catering to users new to Sylus and Usercss. Though I would suggest simply linking to https://github.com/openstyles/stylus/wiki/Usercss#how-do-i-install-usercss in the GitHub-Dark installation instructions. The documentation has all the information covering different approaches to installing Usercss.
As someone that comes from legacy extensions where this was the approach to "install" a style, I parsed the GitHub-Dark installation instructions as: (1) install extension; (2) create new style, paste css into editor, check and if required adjust scope, click apply.
We never recommended that method, the instructions should be clear as to click here or something like it use to be.
See the new install instructions https://github.com/StylishThemes/GitHub-Dark/commit/6481d41c82dfd540560853a233192b209f4fd2ed
Should resolve issue.