Some border issues - Githubissues

StylishThemes / GitHub-Dark

:octocat: Dark GitHub style

https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css

BSD 2-Clause "Simplified" License

9.67k stars 654 forks source link

Some border issues #1287

Open Geeyun-JY3 opened 3 years ago

Geeyun-JY3 commented 3 years ago

Browser: Cent Browser 4.3.9.248 (64-bit) (Chromium 86.0.4240.198), Chrome 87.0.4280.141 (Official Build) (64-bit)
Operating System: Windows 10 20H2 19042.685
Link to page with the issue:
1. Dashboard: https://github.com/
2. PR: https://github.com/sindresorhus/refined-github/pull/3837
3. User's own comment box
Screenshot:
1. Two rounded corners of the Show more button in the dashboard is not sleek. Casue its native dark theme looks good: Maybe a GitHub's native light theme bug:
2. One of the horizontal rule in mergeability box: Edited: Maybe also a GitHub bug
3. User's own comment box A little bit difference if zoomed in

Geeyun-JY3 commented 3 years ago

The border of Refined GitHub’s pinned issue list layout also has this bug (enable clean-pinned-issues) gif

the-j0k3r commented 3 years ago

iii: if you see the alignment issue when zoomed in its a upstream bug, you dont actually say in which conditions iii is manifested.

you may want to also test with https://github.com/StylishThemes/Feature-Override-Styles/blob/master/github-custom-border-radii.user.css installed

Geeyun-JY3 commented 3 years ago

ii seems got fixed by GHD now…One of the recent versions

the-j0k3r commented 3 years ago

Still looks like a border-radius issue that maybe fixed with the style I mentioned.

Geeyun-JY3 commented 3 years ago

Still looks like a border-radius issue that maybe fixed with the style I mentioned.

Tested. Can't fix it.

the-j0k3r commented 3 years ago

and have you disabled refined github to see if it its not it causing it?

Geeyun-JY3 commented 3 years ago

and have you disabled refined github to see if it its not it causing it?

Tested. RGH didn't cause it.

the-j0k3r commented 3 years ago

Well I can t help you further, I dont use style anymore and as such cant really fix it for you, so you'll have to wait for someone to get to it.

Also I can say with some certainty that some border issues you reported exist upstream, but due to styling colors the issues arent so on your face obvious, though some issues with borders may be caused by this style because it adds many opinionated overrides that cause issues.

You cant however just switch style between on off and not refresh page, cause the local css will still be loaded in memory.

I can recommend you choose in settings background ---> none I bet some of these are caused by it.

MarcelCoding commented 3 years ago

Also for diffs in e.g. pull requests or commits:

the-j0k3r commented 3 years ago

@MarcelCoding I can recommend you choose in settings background ---> none, these issues are related to backgrounds where there shouldn't be any.

MarcelCoding commented 3 years ago

@the-j0k3r This actually does not fix the bug. In the developer tools I tried to add overflow: hidden (on the element with the border) and it solved the problem.

silverwind commented 3 years ago

Dashboard: https://github.com/

Is fixed, the others I could not reproduce.

MarcelCoding commented 3 years ago

@silverwind this error still occurs: https://github.com/cryptic-game/java-backend/pull/277/files If you hover over it you will see it much better.

silverwind commented 3 years ago

Can't see an issue on that expander button besides inaccurate border radius, but that's GH's fault.

MarcelCoding commented 3 years ago

Maybe it depends on the browser? I use firefox

silverwind commented 3 years ago

Unlikely. Try with latest version which has some fixes around diffs, otherwise link some more pages with such issues.

MarcelCoding commented 3 years ago

I've just updated the theme. Tomorrow I will post some more issues.

the-j0k3r commented 3 years ago

As I already said part of the issue is the image backgrounds, you cant have any selected.

MarcelCoding commented 3 years ago

https://github.com/spring-projects-experimental/spring-native/commit/863b80cd2b1fbcc137d5c70c72c8e92c03c79e0c

No matter what background I select, the background is always overlapping.

the-j0k3r commented 3 years ago

No matter what background I select, the background is always overlapping.

It must be set to none.

Capture

MarcelCoding commented 3 years ago

I don't know what I am doing wrong. I am gonna keep it as it is. I tried every background including none. Thank you for your help.

silverwind commented 3 years ago

Those green backgrounds look fine again to me. It's hard to see what is actually wrong in your screenshot. Can you zoom in the page?

MarcelCoding commented 3 years ago

@silverwind If you open the link and hover over it you can clearly see that the blue background is overlapping. Unfortunately I can't take screenshots while I am hovering over the element.

MarcelCoding commented 3 years ago

silverwind commented 3 years ago

Looks fine to me even when hovering. Try reinstalling the style.

MarcelCoding commented 3 years ago

That also don't solve the problem. I will accept it as it is.