Closed fanninpm closed 3 years ago
Entire theme is un-usable, wtf did Github do
Still 4.3.114 here, can confirm it's a Github-side fuck-up.
By the way, changing the current GitHub theme from Default light
to Default dark
alleviates the issue temporarily.
By the way, changing the current GitHub theme from
Default light
toDefault dark
alleviates the issue temporarily.
Thank you for the suggestion! Definitely a night and day difference.
Personally I'd say the Dark dimmed
is even closer to the earlier theme.
For anyone struggling to use github at all right now, here's a link to the preferences page where you can change it: https://github.com/settings/appearance
They added !important
to a lot of classes...
They added
!important
to a lot of classes...
Not quite, they are now using different CSS vars depends on what page you visit, this is one, profile another, none of these are important anything, which is what is broken on screenshot.
the old bg-white
has been slowly being replaced with color-bg-primary
which is an Important property, like in notifications and other pages, repo pins etc.
Im not a fan of their choices but they do make them no matter what, please do send feedback to GitHub in a constructive positive manner so it doesn't get dismissed. Only then we can have more sensible choices.
Because lets face it, they provide their own internal styles and those dont break so much, except where some developers are using still inline colors without using the vars at all/
This style even though it sports all the modded css vars included the new in use, is in wrong subdomain and other unique weirdness due to the old design + new github CSS vars dont play well with how this style is done via generator. So this types things will happen more often.
Im locking this discussion to prevent more me too reports and nothing else will be of value.
Im sure when the cron job runs the auto update will fix these anyway without anyone interacting.