search

StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.67k stars 655 forks source link

Replace Grunt with a build script #282

Closed silverwind closed 8 years ago

silverwind commented 8 years ago

So, grunt is going a bit out of fashion and it's getting hard to find plugins. There's gulp but I'm not really sure I want to tie us into another ecosystem which may or may not survive in the long-term.

All our tools expose a Node.js API, so I think a build.js script might be in order. It definitely is much more flexible than grunt, gulp or even make could ever be.

@Mottie I'll get started on it once we know which of the current Grunt tasks we need to replicate. Do we really need the custom style generation with build.json? I'm not sure anyone's really using it. Also, what about user and usermin? I think we can drop user? Oh, and are you using dev?

Mottie commented 8 years ago

Go for it...

The only build I use now is grunt user as it creates the version I copy and paste into userstyles.org.

Yeah, I think we can drop the custom build as well since we have the userscript up and running.

silverwind commented 8 years ago

I'll make sure to also include a version bumping mechanism that generates the changelog from recent commits. Are you fine with using a CHANGELOG.md for that purpose?

Mottie commented 8 years ago

Sure, it'll save me some work :grin:

Mottie commented 8 years ago

Or, we could just drop the change log?

silverwind commented 8 years ago

So, you never used usermin? Maybe we shall I drop minification completely, until size is a concern again?

Mottie commented 8 years ago

Yeah, I don't minify at all since we got a little more breathing room on userstyles.

silverwind commented 8 years ago

Hmm yeah, let's drop the changelog. The commit history ought to be good enough :)

silverwind commented 8 years ago

Might be a good opportunity to use shelljs.

silverwind commented 8 years ago

Having used gulp recently on one of my projects, I think it'd be a great replacement for grunt. The nice thing about it is that you can use custom code sections everywhere in the pipeline, and the plugin ecosystem is vast, too.

Mottie commented 8 years ago

If you want to work on it, I don't mind. I haven't used gulp that much but I'm sure I can figure it out.

silverwind commented 8 years ago

Will follow up with something for https://github.com/StylishThemes/New-GitHub-Dark.