Closed Mottie closed 11 years ago
I'll have a look later at what broke. Looking forward to using the CSS preprocessors too, as I always wanted to check them out.
Let me push the fixes I have so far... I know there is still a problem with new notifications (including hovering).
On first glance, I can see the green "comment" button on issues has a unfitting hover effect, and the green "compare and review" button on repo pages got changed too.
Do you wanna keep the flat green style on these? I'd probably prefer a gradient on them.
Alright, I think I've fixed most button and link colors now, still got to improve the file list and readme boxes later.
Wow! (might be unrelated to this issue) I really like the Color Scheme change! I was actually going to propse a pull request with that in, but you already got it! That's great :)
@Mottie Let me know who you like the slightly darker background in some boxes. I think it sets the content better apart from the background. Although, it may just be a tiny bit too dark after all. @ddavison thanks! glad you like it.
@silverwind! I trust your judgement :)
Personally, I wouldn't mind some gradients... I was just trying to go along with the new "in" thing with flat designs (e.g. Bootstrap); I don't think mobile devices can use the stylish addon, so it really shouldn't matter, but hey shrug
Yep, even GitHub's style is matches flat with gradient and pseudo-3d when you look at this issue on the default style. I'd say we keep the gradients on buttons, but maybe make them a bit less obvious, like going from #181818 to #282828 on the grey ones for example.
Also, care if I remove a few vendor prefixes? linear-gradient for example was unprefixed quite some time ago in both browsers
edit: already commited :)
The gradients on the buttons are growing on me. I do like flat styles better, but I'm starting to think the gradients look fine :smile:
I'm really liking the flat green buttons. (PR, New Issue, Comment, etc)
I'm not sure what has been done or still needs to be done... should I tag the next update?
@ddavison I also added you as a collaborator :)
It's mostly in good shape, with a few color issues left, but nothing major I suppose.
:+1: everything's looking really good
@Mottie Thanks!!
By the way, if you want to add any other variables, just tell me, all you need to do is pick a name and follow this format:
.selector {
color: /*[[mycolor]]*/;
font-face: /*[[myfont]]*/;
}
just don't go too nuts, I do have to manually modify the css before I paste it over on userstyles.
But on a positive note, maybe someday the style will automatically update from github
oh wow! I just realized that you are the owner of Stackoverflow-Dark too! Very cool! i'll definitely be contributing to that as well. I actually made my own so theme : http://userstyles.org/styles/95141/stackoverflow-wide
and wow... SO: Dark + SO: Wide = Awesome.
I made that style a long time ago, I only recently added it to Github
LOL I added you as a collaborator over there too :p
nice! :D I might just push a branch out there to include my "wide" combined with the "dark"
Thanks again to both of you for all the help!
Guys this is looking great! i love my blood red theme! :D
I just made an update which I'm sure broke a few styles. So I would appreciate any help in tracking them down :)
Note: I see there are requests for allowing LESS and/or SCSS to be used with stylish, so we can look forward to that for offset colors. But for now, I didn't bother with them (e.g. calendar contribution colors).
Note 2: My new favorite base color is teal
#008080
:cake: