StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.67k stars 654 forks source link

More github.com subdomains #719

Closed Mottie closed 6 years ago

Mottie commented 6 years ago

I'm looking for feedback on if we should include the following pages with this style:

It looks like it will need some minor tweaks to get it working, but not too bad.

the-j0k3r commented 6 years ago

Neat, why not?

Also why not add https://styleguide.github.com to that?

Mottie commented 6 years ago

I hesitate to add https://styleguide.github.com/primer/ because its a css framework based on a white color scheme.

Especially look at this page - https://styleguide.github.com/primer/utilities/colors/ - none of the defined colors would match what is being described. And, the syntax highlighting, PrettyLights I presume, doesn't match our settings since it doesn't have the "pl-" prefix on the class names.

xt0rted commented 6 years ago

I don't think any of these pages should be covered by this theme.

https://styleguide.github.com (some of the pages are restricted to the github org only) https://hubot.github.com https://slack.github.com https://desktop.github.com

All of these are github pages (like https://primer.github.io/) but hosted with github.com to convey being owned by them and not a community project.

xt0rted commented 6 years ago

On the topic of this, can graphql-explorer.githubapp.com be removed from the url rules since it redirects to https://developer.github.com/v4/explorer/ now?

Mottie commented 6 years ago

The url https://graphql-explorer.githubapp.com/, does redirect to the developer subdomain, but the graphql explorer still runs within an iframe from githubapp.com. If you remove the entry in GitHub Dark, the iframe content turns white.

silverwind commented 6 years ago

I'd reduce the list of sites to what is absolutely neccessary for powerusers (novices would not find or install our style anways). For me, that's github.com, gist, news and status, as well as framed content on these sites.

xt0rted commented 6 years ago

I'd also include the blog since they've been posting more frequent updates to it, such as at https://blog.github.com/changelog/

the-j0k3r commented 6 years ago

Whatever is happening dont take away from whats currently supported :)

silverwind commented 6 years ago

also include the blog

That's what I meant with "news" 😉

xt0rted commented 6 years ago

They have so many subdomains now I thought news.github.com was a real page