StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.65k stars 653 forks source link

How to make code deltas easier to read? (cascadea) #808

Closed irace closed 5 years ago

irace commented 5 years ago

Hello – I am using the Cascadea for macOS to apply the GitHub Dark usercss, and am finding the code deltas very hard to read:

screen shot 2018-12-27 at 11 14 52 pm

In particular, the blue text is hard to read on both the red and green backgrounds.

Am I doing anything wrong? Is there an easy way to change the syntax highlighting to be a bit more legible?

Thanks in advance for your help.

the-j0k3r commented 5 years ago

Hi and thanks you for reaching out. If Cascadea supports full usercss (Im unfamiliar with Cascadea btw), it should show the GitHub Dark usercss menu like so.

usercss

If not then an alternative maybe the Github Dark Script or consider using another browser and Stylus.

Hope that helps.

silverwind commented 5 years ago

Looks like your style extension does not support usercss options or does not implement them fully. Maybe try the non-usercss version.

Mottie commented 5 years ago

Hi @irace!

Since Cascadea doesn't currently support the UserCSS format, I think your only option is to create a new style and paste your desired syntax highlighting theme(s) into it. GitHub uses 3 different themes:

I'm not sure how to contact the developers of Cascadea to make an enhancement request, but we have a UserCSS meta parser & spec available.

irace commented 5 years ago

Thanks all – using the non-usercss version that @silverwind linked to seems to have improved things greatly. I’d still rather Cascadea add support for UserCSS, so I'll try following up with the developer.

the-j0k3r commented 5 years ago

I’d still rather Cascadea add support for UserCSS, so I'll try following up with the developer.

Thats good to hear, fingers crossed on usercss front. I also looked at his privacy policy and looks simple similar to Stylus, however there's no code available to audit. Sure would make things more transparent if it were. :)

I m sure it goes without saying but feel free to link this report to Cascadea's dev.

Good luck and happy to see silverwinds solution worked for you. :)

mikefreuden commented 5 years ago

Hi there! I'm the developer of Cascadea. Just wanted to update you all on this particular issue. I just pushed Cascadea 1.3 to the App Store, which should correctly parse and apply UserCSS variables so that the UserCSS version of this style looks correct. Previous releases didn't really handle UserCSS variables at all, so any properties that depend on variables just, well, didn't work, which resulted in a lot of broken properties in Github Dark. Now the default values should be applied. (I'm actually using Github Dark in Cascadea 1.3 as I type this!)

I'm still working on implementing UI for actually customizing variables, which should hopefully be in the next release.

the-j0k3r commented 5 years ago

@mikefreuden

Ive updated our wiki page related to Cascadea to reflect this information so if there are any new advances or more up-to-date info feel free to let us know.

=)

mikefreuden commented 5 years ago

One (hopefully last) update for you all. Cascadea 1.4 adds UI for customizing @advanced and @var UserCSS variables, so using Cascadea should now provide a first-class GitHub Dark experience. :)

Screen Shot 2019-06-11 at 9 08 26 AM
silverwind commented 5 years ago

Thanks. Readme updated.

the-j0k3r commented 5 years ago

Ive updated the wiki page =) Will also give it a whirl in my text macOS vm