StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.66k stars 654 forks source link

Diff toolbar has background color when not sticky #849

Closed xt0rted closed 5 years ago

xt0rted commented 5 years ago

You can see this by viewing the Files changed tab of any PR.

It looks like this is happening because .diffbar has a background color set for when you scroll and it gets stuck to the top. I think we need to increase the specificity of this selector to .pr-toolbar.is-stuck .diffbar.

A quick test shows that works, but it also needs to have it's background set to transparent when not stuck.

image

<div class="pr-toolbar js-sticky js-sticky-offset-scroll" style="position: sticky;">
          <div class="diffbar details-collapse js-details-container Details">
            <div class="show-if-stuck float-left mr-2 mt-2">
                <div class="State State--green">
    <svg class="octicon octicon-git-pull-request" viewBox="0 0 12 16" version="1.1" width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M11 11.28V5c-.03-.78-.34-1.47-.94-2.06C9.46 2.35 8.78 2.03 8 2H7V0L4 3l3 3V4h1c.27.02.48.11.69.31.21.2.3.42.31.69v6.28A1.993 1.993 0 0 0 10 15a1.993 1.993 0 0 0 1-3.72zm-1 2.92c-.66 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2zM4 3c0-1.11-.89-2-2-2a1.993 1.993 0 0 0-1 3.72v6.56A1.993 1.993 0 0 0 2 15a1.993 1.993 0 0 0 1-3.72V4.72c.59-.34 1-.98 1-1.72zm-.8 10c0 .66-.55 1.2-1.2 1.2-.65 0-1.2-.55-1.2-1.2 0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2zM2 4.2C1.34 4.2.8 3.65.8 3c0-.65.55-1.2 1.2-1.2.65 0 1.2.55 1.2 1.2 0 .65-.55 1.2-1.2 1.2z"></path></svg>
    Open
  </div>

            </div>

            <div class="float-left">
              <div class="show-if-stuck">
                <h1 class="text-bold f5">
  <a class="js-issue-title css-truncate css-truncate-target link-gray-dark" href="#" style="max-width: 38em">Adjusting  lock and repo suggestion name color</a>
  <span class="gh-header-number text-gray-light pr-1">#827</span>
</h1>

              </div>
              <div>

<details class="details-reset details-overlay diffbar-item diffbar-range-menu select-menu js-diffbar-commits-menu">
  <summary class="btn-link muted-link select-menu-button" data-hotkey="c" aria-haspopup="menu">
      Changes from <strong>all commits</strong>
  </summary>

  <details-menu class="select-menu-modal position-absolute" style="z-index: 99;" role="menu">
    <div class="select-menu-header">
      <span class="select-menu-title">Commits</span>
    </div>
    <div class="select-menu-list">
      <a href="/StylishThemes/GitHub-Dark/pull/827/files" class="select-menu-item" role="menuitem">
        <div class="select-menu-item-text">
          <div class="text-emphasized css-truncate css-truncate-target">
            Show all changes
          </div>
          <span class="description">
            7 commits
          </span>
        </div>
      </a>

          <a href="/StylishThemes/GitHub-Dark/pull/827/files/338ee06f5ddcb44de4964a90d83021d040c22b36..HEAD" class="select-menu-item" role="menuitem">
            <div class="select-menu-item-text">
              <div class="text-emphasized css-truncate css-truncate-target">
                Show changes since your last review
              </div>
              <span class="description">
                1 commit
              </span>
            </div>
          </a>

      <div class="select-menu-divider">
        Select commit
          <span class="note text-normal mt-0 float-right">Hold shift + click to select a range</span>
      </div>

      <div class="js-diffbar-commits-list" data-range-url="/StylishThemes/GitHub-Dark/pull/827/files/$range">
          <a href="/StylishThemes/GitHub-Dark/pull/827/commits/882f0983b5588878a9b52b29d88746bcde312a61" class="select-menu-item " role="menuitem" data-commit="882f098">

            <div class="select-menu-item-text">
              <code class="float-right">882f098</code>
              <div class="text-emphasized css-truncate css-truncate-target">
                Adjusting lock / suggestion name color
              </div>
              <span class="description">
                Otman404 <relative-time datetime="2019-01-10T19:49:13Z" title="Jan 10, 2019, 2:49 PM EST">on Jan 10</relative-time>
              </span>
            </div>
          </a>
          <a href="/StylishThemes/GitHub-Dark/pull/827/commits/c404e85c2dc074c7d2f86ce1c0b8265ac9aecf99" class="select-menu-item " role="menuitem" data-commit="c404e85" data-parent-commit="882f098">

            <div class="select-menu-item-text">
              <code class="float-right">c404e85</code>
              <div class="text-emphasized css-truncate css-truncate-target">
                Update github-dark.css
              </div>
              <span class="description">
                Otman404 <relative-time datetime="2019-01-10T23:42:54Z" title="Jan 10, 2019, 6:42 PM EST">on Jan 10</relative-time>
              </span>
            </div>
          </a>
          <a href="/StylishThemes/GitHub-Dark/pull/827/commits/0f8d3df5f1395f65a16dd96677ee33b8ab31133c" class="select-menu-item " role="menuitem" data-commit="0f8d3df" data-parent-commit="c404e85">

            <div class="select-menu-item-text">
              <code class="float-right">0f8d3df</code>
              <div class="text-emphasized css-truncate css-truncate-target">
                address comments
              </div>
              <span class="description">
                the-j0k3r <relative-time datetime="2019-01-11T15:43:43Z" title="Jan 11, 2019, 10:43 AM EST">on Jan 11</relative-time>
              </span>
            </div>
          </a>
          <a href="/StylishThemes/GitHub-Dark/pull/827/commits/0917965a251e364a9fcd8828ba9b65b362a61ee5" class="select-menu-item " role="menuitem" data-commit="0917965" data-parent-commit="0f8d3df">

            <div class="select-menu-item-text">
              <code class="float-right">0917965</code>
              <div class="text-emphasized css-truncate css-truncate-target">
                typo trailing space + selector move
              </div>
              <span class="description">
                the-j0k3r <relative-time datetime="2019-01-11T15:47:35Z" title="Jan 11, 2019, 10:47 AM EST">on Jan 11</relative-time>
              </span>
            </div>
          </a>
          <a href="/StylishThemes/GitHub-Dark/pull/827/commits/7250b94d513b42f763f4eca89a39735a38de383a" class="select-menu-item " role="menuitem" data-commit="7250b94" data-parent-commit="0917965">

            <div class="select-menu-item-text">
              <code class="float-right">7250b94</code>
              <div class="text-emphasized css-truncate css-truncate-target">
                Changed private repository lock symbol color
              </div>
              <span class="description">
                the-j0k3r <relative-time datetime="2019-01-11T16:03:50Z" title="Jan 11, 2019, 11:03 AM EST">on Jan 11</relative-time>
              </span>
            </div>
          </a>
          <a href="/StylishThemes/GitHub-Dark/pull/827/commits/338ee06f5ddcb44de4964a90d83021d040c22b36" class="select-menu-item " role="menuitem" data-commit="338ee06" data-parent-commit="7250b94">

            <div class="select-menu-item-text">
              <code class="float-right">338ee06</code>
              <div class="text-emphasized css-truncate css-truncate-target">
                use #cb4 for lock colors
              </div>
              <span class="description">
                the-j0k3r <relative-time datetime="2019-01-17T10:32:42Z" title="Jan 17, 2019, 5:32 AM EST">27 days ago</relative-time>
              </span>
            </div>
          </a>
          <a href="/StylishThemes/GitHub-Dark/pull/827/commits/3aa34493eeca90e0deb927148244b9cb605b1de6" class="select-menu-item " role="menuitem" data-commit="3aa3449" data-parent-commit="338ee06">

            <div class="select-menu-item-text">
              <code class="float-right">3aa3449</code>
              <div class="text-emphasized css-truncate css-truncate-target">
                remove already covered selector
              </div>
              <span class="description">
                the-j0k3r <relative-time datetime="2019-01-25T09:37:39Z" title="Jan 25, 2019, 4:37 AM EST">19 days ago</relative-time>
              </span>
            </div>
          </a>
      </div>
    </div>
  </details-menu>
</details>

                  <details class="diffbar-item details-reset details-overlay select-menu d-inline-block position-relative js-file-filter">
  <summary class="muted-link select-menu-button" data-ga-click="Pull Requests, open file types filter" aria-haspopup="menu">
    <span class="select-menu-title">
      <strong class="js-file-filter-text css-truncate css-truncate-target">
        File filter...
      </strong>
    </span>
  </summary>

  <details-menu class="select-menu-modal position-absolute left-0" style="z-index: 99;" role="menu">
    <div class="select-menu-header d-flex flex-justify-between">
      <span class="select-menu-title">Filter file types</span>
    </div>
    <div class="select-menu-list" role="menu">
      <form class="js-file-filter-form">
        <div class="p-2">
            <div class="d-flex">
              <label class="pl-1 mb-1" style="cursor:pointer;">
                <input class="js-diff-file-type-option" style="cursor:pointer;" type="checkbox" value=".css" name="file-filters[]" data-non-deleted-files-count="1" data-deleted-files-count="0" checked="">
                .css
                <span class="text-normal js-file-type-count" data-non-deleted-file-count-markup="(1)" data-all-file-count-markup="(1)">
                  (1)
                </span>
              </label>
            </div>
          <div class="ml-1">
            <label style="cursor:pointer;">
              <input type="checkbox" class="js-file-filter-select-all" hidden="">
              <span class="text-gray no-underline text-normal js-file-filter-select-all-container" data-select-all-markup="Select all 1 file type" data-all-selected-markup="All 1 file type selected">
                All 1 file type selected
              </span>
            </label>
          </div>
        </div>

      </form>
    </div>
  </details-menu>
</details>

<details class="details-reset details-overlay diffbar-item toc-select select-menu">
  <summary class="btn-link muted-link select-menu-button" data-hotkey="t" data-ga-click="Pull Requests, open table of contents, type:semantic" aria-haspopup="menu">
    <strong>Jump to…</strong>
  </summary>
  <details-menu class="select-menu-modal position-absolute" style="z-index: 99;" src="/StylishThemes/GitHub-Dark/pull/827/show_toc?base_sha=6c61d52cc041c5b4693164754c6ab6ac716d3ff2&amp;sha1=6c61d52cc041c5b4693164754c6ab6ac716d3ff2&amp;sha2=3aa34493eeca90e0deb927148244b9cb605b1de6" preload="" role="menu">
      <div class="select-menu-header">
        <span class="select-menu-title">
          Jump to file or symbol
        </span>
      </div>
      <include-fragment>
        <div class="select-menu-blankslate select-menu-error">
          Failed to load files and symbols. <button type="button" class="btn-link js-toc-retry">Retry</button>
        </div>
        <div class="select-menu-loading-overlay anim-pulse">
          <svg height="32" aria-label="Loading" class="octicon octicon-octoface" viewBox="0 0 16 16" version="1.1" width="32" role="img"><path fill-rule="evenodd" d="M14.7 5.34c.13-.32.55-1.59-.13-3.31 0 0-1.05-.33-3.44 1.3-1-.28-2.07-.32-3.13-.32s-2.13.04-3.13.32c-2.39-1.64-3.44-1.3-3.44-1.3-.68 1.72-.26 2.99-.13 3.31C.49 6.21 0 7.33 0 8.69 0 13.84 3.33 15 7.98 15S16 13.84 16 8.69c0-1.36-.49-2.48-1.3-3.35zM8 14.02c-3.3 0-5.98-.15-5.98-3.35 0-.76.38-1.48 1.02-2.07 1.07-.98 2.9-.46 4.96-.46 2.07 0 3.88-.52 4.96.46.65.59 1.02 1.3 1.02 2.07 0 3.19-2.68 3.35-5.98 3.35zM5.49 9.01c-.66 0-1.2.8-1.2 1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8 1.2-1.79s-.54-1.78-1.2-1.78zm5.02 0c-.66 0-1.2.79-1.2 1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8 1.2-1.79s-.53-1.78-1.2-1.78z"></path></svg>
        </div>
      </include-fragment>
  </details-menu>
</details>

                  <span class="diffbar-item diffstat">
  <span class="text-green">
    +3
  </span>
  <span class="text-red">
    -2
  </span>
  <span class="tooltipped tooltipped-s" aria-label="5 lines changed">
    <span class="block-diff-added"></span><span class="block-diff-added"></span><span class="block-diff-added"></span><span class="block-diff-deleted"></span><span class="block-diff-deleted"></span>
  </span>
</span>

              </div>
            </div>

            <div class="float-right pr-review-tools">
              <details class="diffbar-item details-reset details-overlay position-relative text-center">
  <summary class="btn btn-sm">
    Diff settings
    <div class="dropdown-caret v-align-text-bottom"></div>
  </summary>
  <div class="Popover js-diff-settings mt-2 pt-1" style="left: -62px">
    <div class="Popover-message text-left p-3 mx-auto Box box-shadow-large">
      <!-- '"` --><!-- </textarea></xmp> --><form action="/StylishThemes/GitHub-Dark/pull/827/files" accept-charset="UTF-8" method="get"><input name="utf8" type="hidden" value="?">
        <h4 class="mb-2">Always</h4>
        <div class="BtnGroup d-flex flex-content-stretch js-diff-style-toggle">
  <label class="flex-auto btn btn-sm BtnGroup-item text-center selected">
    <input class="sr-only" value="unified" name="diff" type="radio" checked="checked">
     Unified
  </label>
  <label class="flex-auto btn btn-sm BtnGroup-item text-center ">
    <input class="sr-only" value="split" name="diff" type="radio">
     Split
  </label>
</div>

        <h4 class="mb-2 mt-3">Just for now</h4>
        <input type="checkbox" name="w" value="1" id="whitespace-cb">
        <label for="whitespace-cb" class="text-normal">Hide whitespace changes</label>
        <button class="btn btn-primary btn-sm col-12 mt-3" type="submit">Apply and reload</button>
</form>    </div>
  </div>
</details>

                <div class="diffbar-item dropdown js-batched-suggested-changes-container" hidden="">
  <details class="details-reset details-overlay js-dropdown-details">
    <summary class="btn btn-sm js-batched-suggested-changes-toggle">
      Commit suggestions
      <span class="Counter d-inline-block js-pending-batched-suggested-changes-count">0</span>
      <span class="dropdown-caret v-align-text-bottom"></span>
    </summary>
    <div class="pull-request-suggested-changes-menu Box box-shadow-medium position-absolute right-0" id="commit-suggestions">
      <!-- '"` --><!-- </textarea></xmp> --><form class="js-batched-suggested-changes-form" data-warn-unsaved-changes="Your batched suggestions will be lost." action="/StylishThemes/GitHub-Dark/suggestions/patch-3" accept-charset="UTF-8" method="post"><input name="utf8" type="hidden" value="?"><input type="hidden" name="authenticity_token" value="...">
        <input type="hidden" name="current_oid" value="3aa34493eeca90e0deb927148244b9cb605b1de6">
        <input type="text" name="commit_title" class="form-control input-block input-contrast merge-commit-title js-suggestion-commit-title text-emphasized mb-2" aria-label="Commit title" value="Apply suggestions from code review" placeholder="Commit title">
        <textarea rows="3" aria-label="Commit message" autocomplete="off" class="js-suggestion-commit-message js-quick-submit form-control input-block mb-2" type="text" name="commit_message" placeholder="Add an optional extended description…" style="resize: vertical"></textarea>
        <div class="form-actions">
          <button type="submit" class="btn btn-sm btn-primary float-left js-suggestion-batch-submit" data-hydro-click="{&quot;event_type&quot;:&quot;suggested_changes.target.click&quot;,&quot;payload&quot;:{&quot;user_id&quot;:831974,&quot;target_type&quot;:&quot;commit_changes&quot;,&quot;pull_request_id&quot;:&quot;MDExOlB1bGxSZXF1ZXN0MjQzODA5OTc1&quot;,&quot;relationship_to_suggestion&quot;:&quot;reviewer&quot;,&quot;client_id&quot;:&quot;790373834.1527194507&quot;,&quot;originating_request_id&quot;:&quot;E9FC:2255:13FB9A:267E3A:5C63E8EA&quot;,&quot;originating_url&quot;:&quot;https://github.com/StylishThemes/GitHub-Dark/pull/827/files?_pjax=%23js-repo-pjax-container&quot;}}" data-hydro-click-hmac="4c6311104bf338650212bab5f5235af1b09dc2817e6bb46a631cc3ba4f2b46e0" data-ga-click="Markdown Toolbar, click, insert code suggestion" data-disable-invalid="true" data-disable-with="Applying commits...">
            Commit changes
</button>        </div>
        <div class="form-group warn m-0 mt-2 js-error-message-container" hidden="">
          <div class="position-relative warning m-0" style="max-width: inherit;">
            <span class="js-error-message"></span>
            Please <span class="text-bold btn-link js-refresh-after-suggestion">refresh</span> and try again.
          </div>
        </div>
</form>    </div>
  </details>
</div>

                <div class="diffbar-item dropdown js-reviews-container">
    <details class="details-reset details-overlay js-dropdown-details">
      <summary class="btn btn-sm btn-primary js-reviews-toggle">
        Review changes
        <span class="Counter js-pending-review-comment-count">
          0
        </span>
        <span class="dropdown-caret v-align-text-bottom"></span>
      </summary>
      <div class="pull-request-review-menu Box box-shadow-medium position-absolute right-0" id="submit-review">
        <!-- '"` --><!-- </textarea></xmp> --><form action="/StylishThemes/GitHub-Dark/pull/827/reviews" accept-charset="UTF-8" method="post"><input name="utf8" type="hidden" value="?"><input type="hidden" name="_method" value="put"><input type="hidden" name="authenticity_token" value="...">
  <input type="hidden" name="head_sha" id="head_sha" value="3aa34493eeca90e0deb927148244b9cb605b1de6" class="form-control">
  <div class="js-suggester-container js-previewable-comment-form previewable-comment-form write-selected" data-preview-url="/preview?markdown_unsupported=false&amp;repository=1219740&amp;subject=827&amp;subject_type=PullRequest" data-preview-authenticity-token="...">
  <div class="comment-form-head tabnav">

<markdown-toolbar for="pull_request_review_body" class="toolbar-commenting">
  <div class="toolbar-group">
    <md-header tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Add header text" data-ga-click="Markdown Toolbar, click, header" role="button">
      <svg class="octicon octicon-text-size" viewBox="0 0 18 16" version="1.1" width="18" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M13.62 9.08L12.1 3.66h-.06l-1.5 5.42h3.08zM5.7 10.13S4.68 6.52 4.53 6.02h-.08l-1.13 4.11H5.7zM17.31 14h-2.25l-.95-3.25h-4.07L9.09 14H6.84l-.69-2.33H2.87L2.17 14H0l3.3-9.59h2.5l2.17 6.34L10.86 2h2.52l3.94 12h-.01z"></path></svg>
    </md-header>

    <md-bold tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Add bold text <ctrl+b>" data-ga-click="Markdown Toolbar, click, bold" hotkey="b" role="button">
      <svg class="octicon octicon-bold" viewBox="0 0 10 16" version="1.1" width="10" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M1 2h3.83c2.48 0 4.3.75 4.3 2.95 0 1.14-.63 2.23-1.67 2.61v.06c1.33.3 2.3 1.23 2.3 2.86 0 2.39-1.97 3.52-4.61 3.52H1V2zm3.66 4.95c1.67 0 2.38-.66 2.38-1.69 0-1.17-.78-1.61-2.34-1.61H3.13v3.3h1.53zm.27 5.39c1.77 0 2.75-.64 2.75-1.98 0-1.27-.95-1.81-2.75-1.81h-1.8v3.8h1.8v-.01z"></path></svg>
    </md-bold>

    <md-italic tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Add italic text <ctrl+i>" data-ga-click="Markdown Toolbar, click, italic" hotkey="i" role="button">
      <svg class="octicon octicon-italic" viewBox="0 0 6 16" version="1.1" width="6" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M2.81 5h1.98L3 14H1l1.81-9zm.36-2.7c0-.7.58-1.3 1.33-1.3.56 0 1.13.38 1.13 1.03 0 .75-.59 1.3-1.33 1.3-.58 0-1.13-.38-1.13-1.03z"></path></svg>
    </md-italic>
  </div>

  <div class="toolbar-group">
    <md-quote tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Insert a quote" data-ga-click="Markdown Toolbar, click, quote" role="button">
      <svg class="octicon octicon-quote" viewBox="0 0 14 16" version="1.1" width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M6.16 3.5C3.73 5.06 2.55 6.67 2.55 9.36c.16-.05.3-.05.44-.05 1.27 0 2.5.86 2.5 2.41 0 1.61-1.03 2.61-2.5 2.61-1.9 0-2.99-1.52-2.99-4.25 0-3.8 1.75-6.53 5.02-8.42L6.16 3.5zm7 0c-2.43 1.56-3.61 3.17-3.61 5.86.16-.05.3-.05.44-.05 1.27 0 2.5.86 2.5 2.41 0 1.61-1.03 2.61-2.5 2.61-1.89 0-2.98-1.52-2.98-4.25 0-3.8 1.75-6.53 5.02-8.42l1.14 1.84h-.01z"></path></svg>
    </md-quote>

    <md-code tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Insert code" data-ga-click="Markdown Toolbar, click, code" role="button">
      <svg class="octicon octicon-code" viewBox="0 0 14 16" version="1.1" width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M9.5 3L8 4.5 11.5 8 8 11.5 9.5 13 14 8 9.5 3zm-5 0L0 8l4.5 5L6 11.5 2.5 8 6 4.5 4.5 3z"></path></svg>
    </md-code>

    <md-link tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Add a link <ctrl+k>" data-ga-click="Markdown Toolbar, click, link" hotkey="k" role="button">
      <svg class="octicon octicon-link" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z"></path></svg>
    </md-link>
  </div>

  <div class="toolbar-group">
    <md-unordered-list tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Add a bulleted list" data-ga-click="Markdown Toolbar, click, unordered list" role="button">
      <svg class="octicon octicon-list-unordered" viewBox="0 0 12 16" version="1.1" width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M2 13c0 .59 0 1-.59 1H.59C0 14 0 13.59 0 13c0-.59 0-1 .59-1h.81c.59 0 .59.41.59 1H2zm2.59-9h6.81c.59 0 .59-.41.59-1 0-.59 0-1-.59-1H4.59C4 2 4 2.41 4 3c0 .59 0 1 .59 1zM1.41 7H.59C0 7 0 7.41 0 8c0 .59 0 1 .59 1h.81c.59 0 .59-.41.59-1 0-.59 0-1-.59-1h.01zm0-5H.59C0 2 0 2.41 0 3c0 .59 0 1 .59 1h.81c.59 0 .59-.41.59-1 0-.59 0-1-.59-1h.01zm10 5H4.59C4 7 4 7.41 4 8c0 .59 0 1 .59 1h6.81c.59 0 .59-.41.59-1 0-.59 0-1-.59-1h.01zm0 5H4.59C4 12 4 12.41 4 13c0 .59 0 1 .59 1h6.81c.59 0 .59-.41.59-1 0-.59 0-1-.59-1h.01z"></path></svg>
    </md-unordered-list>

    <md-ordered-list tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Add a numbered list" data-ga-click="Markdown Toolbar, click, ordered list" role="button">
      <svg class="octicon octicon-list-ordered" viewBox="0 0 12 16" version="1.1" width="12" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M12.01 13c0 .59 0 1-.59 1H4.6c-.59 0-.59-.41-.59-1 0-.59 0-1 .59-1h6.81c.59 0 .59.41.59 1h.01zM4.6 4h6.81C12 4 12 3.59 12 3c0-.59 0-1-.59-1H4.6c-.59 0-.59.41-.59 1 0 .59 0 1 .59 1zm6.81 3H4.6c-.59 0-.59.41-.59 1 0 .59 0 1 .59 1h6.81C12 9 12 8.59 12 8c0-.59 0-1-.59-1zm-9.4-6h-.72c-.3.19-.58.25-1.03.34V2h.75v2.14H.17V5h2.84v-.86h-1V1zm.392 8.12c-.129 0-.592.04-.802.07.53-.56 1.14-1.25 1.14-1.89C2.72 6.52 2.18 6 1.38 6c-.59 0-.97.2-1.38.64l.58.58c.19-.19.38-.38.64-.38.28 0 .48.16.48.52 0 .53-.77 1.2-1.7 2.06V10h3v-.88h-.598zm-.222 3.79v-.03c.44-.19.64-.47.64-.86 0-.7-.56-1.11-1.44-1.11-.48 0-.89.19-1.28.52l.55.64c.25-.2.44-.31.69-.31.27 0 .42.13.42.36 0 .27-.2.44-.86.44v.75c.83 0 .98.17.98.47 0 .25-.23.38-.58.38-.28 0-.56-.14-.81-.38l-.48.66c.3.36.77.56 1.41.56.83 0 1.53-.41 1.53-1.16 0-.5-.31-.81-.77-.94v.01z"></path></svg>
    </md-ordered-list>

    <md-task-list tabindex="-1" class="toolbar-item tooltipped tooltipped-n" aria-label="Add a task list" data-ga-click="Markdown Toolbar, click, task list" hotkey="L" role="button">
      <svg class="octicon octicon-tasklist" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M15.41 9H7.59C7 9 7 8.59 7 8c0-.59 0-1 .59-1h7.81c.59 0 .59.41.59 1 0 .59 0 1-.59 1h.01zM9.59 4C9 4 9 3.59 9 3c0-.59 0-1 .59-1h5.81c.59 0 .59.41.59 1 0 .59 0 1-.59 1H9.59zM0 3.91l1.41-1.3L3 4.2 7.09 0 8.5 1.41 3 6.91l-3-3zM7.59 12h7.81c.59 0 .59.41.59 1 0 .59 0 1-.59 1H7.59C7 14 7 13.59 7 13c0-.59 0-1 .59-1z"></path></svg>
    </md-task-list>
  </div>

  <div class="toolbar-group">
    <md-mention tabindex="-1" class="toolbar-item tooltipped tooltipped-nw" aria-label="Directly mention a user or team" data-ga-click="Markdown Toolbar, click, mention" role="button">
      <svg class="octicon octicon-mention" viewBox="0 0 14 16" version="1.1" width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M6.58 15c1.25 0 2.52-.31 3.56-.94l-.42-.94c-.84.52-1.89.83-3.03.83-3.23 0-5.64-2.08-5.64-5.72 0-4.37 3.23-7.18 6.58-7.18 3.45 0 5.22 2.19 5.22 5.2 0 2.39-1.34 3.86-2.5 3.86-1.05 0-1.36-.73-1.05-2.19l.73-3.75H8.98l-.11.72c-.41-.63-.94-.83-1.56-.83-2.19 0-3.66 2.39-3.66 4.38 0 1.67.94 2.61 2.3 2.61.84 0 1.67-.53 2.3-1.25.11.94.94 1.45 1.98 1.45 1.67 0 3.77-1.67 3.77-5C14 2.61 11.59 0 7.83 0 3.66 0 0 3.33 0 8.33 0 12.71 2.92 15 6.58 15zm-.31-5c-.73 0-1.36-.52-1.36-1.67 0-1.45.94-3.22 2.41-3.22.52 0 .84.2 1.25.83l-.52 3.02c-.63.73-1.25 1.05-1.78 1.05V10z"></path></svg>
    </md-mention>

    <md-ref tabindex="-1" class="toolbar-item tooltipped tooltipped-nw" aria-label="Reference an issue or pull request" data-ga-click="Markdown Toolbar, click, reference" role="button">
      <svg class="octicon octicon-bookmark" viewBox="0 0 10 16" version="1.1" width="10" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M9 0H1C.27 0 0 .27 0 1v15l5-3.09L10 16V1c0-.73-.27-1-1-1zm-.78 4.25L6.36 5.61l.72 2.16c.06.22-.02.28-.2.17L5 6.6 3.12 7.94c-.19.11-.25.05-.2-.17l.72-2.16-1.86-1.36c-.17-.16-.14-.23.09-.23l2.3-.03.7-2.16h.25l.7 2.16 2.3.03c.23 0 .27.08.09.23h.01z"></path></svg>
    </md-ref>

      <details class="details-reset details-overlay toolbar-item select-menu select-menu-modal-right js-saved-reply-container" tabindex="-1">
        <summary class="menu-target" aria-label="Insert a reply" data-ga-click="Markdown Toolbar, click, saved reply" aria-haspopup="menu">
          <svg class="octicon octicon-reply" viewBox="0 0 14 16" version="1.1" width="14" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M6 3.5c3.92.44 8 3.125 8 10-2.312-5.062-4.75-6-8-6V11L.5 5.5 6 0v3.5z"></path></svg>
          <span class="dropdown-caret"></span>
        </summary>
        <details-menu class="select-menu-modal position-absolute right-0" style="z-index: 99;" src="/settings/replies?context=pull_request_comment" preload="" role="menu">
          <div class="select-menu-header d-flex">
            <span class="select-menu-title flex-auto">Select a reply</span>
            <code><span class="border rounded-1 p-1 mr-2">ctrl .</span></code>
          </div>
          <include-fragment class="select-menu-loading-overlay anim-pulse" aria-label="Loading">
            <svg class="octicon octicon-octoface" viewBox="0 0 16 16" version="1.1" width="16" height="16" aria-hidden="true"><path fill-rule="evenodd" d="M14.7 5.34c.13-.32.55-1.59-.13-3.31 0 0-1.05-.33-3.44 1.3-1-.28-2.07-.32-3.13-.32s-2.13.04-3.13.32c-2.39-1.64-3.44-1.3-3.44-1.3-.68 1.72-.26 2.99-.13 3.31C.49 6.21 0 7.33 0 8.69 0 13.84 3.33 15 7.98 15S16 13.84 16 8.69c0-1.36-.49-2.48-1.3-3.35zM8 14.02c-3.3 0-5.98-.15-5.98-3.35 0-.76.38-1.48 1.02-2.07 1.07-.98 2.9-.46 4.96-.46 2.07 0 3.88-.52 4.96.46.65.59 1.02 1.3 1.02 2.07 0 3.19-2.68 3.35-5.98 3.35zM5.49 9.01c-.66 0-1.2.8-1.2 1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8 1.2-1.79s-.54-1.78-1.2-1.78zm5.02 0c-.66 0-1.2.79-1.2 1.78s.54 1.79 1.2 1.79c.66 0 1.2-.8 1.2-1.79s-.53-1.78-1.2-1.78z"></path></svg>
          </include-fragment>
        </details-menu>
      </details>
  </div>
</markdown-toolbar>

      <nav class="tabnav-tabs" role="tablist">
        <button type="button" class="btn-link tabnav-tab write-tab js-write-tab selected" role="tab" aria-selected="true">Write</button>
        <button type="button" class="btn-link tabnav-tab preview-tab js-preview-tab" role="tab">Preview</button>
      </nav>
  </div>

  <div class="comment-form-error js-comment-form-error" style="display:none">    There was an error creating your PullRequest.
</div>
  <file-attachment class="js-upload-markdown-image is-default" data-upload-repository-id="1219740" data-upload-policy-url="/upload/policies/assets" data-upload-policy-authenticity-token="...">
    <div class="write-content js-write-bucket upload-enabled js-reaction-suggestion tooltipped tooltipped-ne tooltipped-no-delay tooltipped-align-left-1 hide-reaction-suggestion" data-reaction-markup="Would you like to leave a reaction instead?">

        <input type="hidden" name="saved_reply_id" class="js-saved-reply-id js-resettable-field" value="" data-reset-value="">

      <textarea name="pull_request_review[body]" id="pull_request_review_body" placeholder="Leave a comment" aria-label="Comment body" class="form-control input-contrast comment-form-textarea js-comment-field js-paste-markdown js-task-list-field js-quick-submit js-suggester-field js-session-resumable js-saved-reply-shortcut-comment-field"></textarea>

          <p class="drag-and-drop position-relative">
    <input accept=".gif,.jpeg,.jpg,.png,.docx,.gz,.log,.pdf,.pptx,.txt,.xlsx,.zip" type="file" multiple="multiple" class="manual-file-chooser top-0 right-0 bottom-0 left-0 width-full ml-0 js-manual-file-chooser form-control" style="opacity: 0.1; min-height: 0;" aria-label="Attach files to your comment">
    <span class="bg-gray-light position-absolute top-0 left-0 width-full height-full rounded-1" style="pointer-events: none;"></span>
    <span class="position-relative" style="pointer-events: none;">
      <span class="default">
          Attach files by dragging &amp; dropping,
          selecting them, or pasting
          from the clipboard.
      </span>
      <span class="loading">
        <img alt="" width="16" height="16" src="https://github.githubassets.com/images/spinners/octocat-spinner-32.gif"> Uploading your files…
      </span>
      <span class="error bad-file">
        We don’t support that file type.
        <span class="drag-and-drop-error-info">
          <button type="button" class="btn-link manual-file-chooser-text">Try again</button> with a
          GIF, JPEG, JPG, PNG, DOCX, GZ, LOG, PDF, PPTX, TXT, XLSX or ZIP.
        </span>
      </span>
      <span class="error bad-permissions">
        Attaching documents requires write permission to this repository.
        <span class="drag-and-drop-error-info">
          <button type="button" class="btn-link manual-file-chooser-text">Try again</button> with a GIF, JPEG, JPG, PNG, DOCX, GZ, LOG, PDF, PPTX, TXT, XLSX or ZIP.
        </span>
      </span>
      <span class="error repository-required">
        We don’t support that file type.
        <span class="drag-and-drop-error-info">
          <button type="button" class="btn-link manual-file-chooser-text">Try again</button> with a GIF, JPEG, JPG, PNG, DOCX, GZ, LOG, PDF, PPTX, TXT, XLSX or ZIP.
        </span>
      </span>
      <span class="error too-big">
        Yowza, that’s a big file
        <span class="drag-and-drop-error-info">
          <button type="button" class="btn-link manual-file-chooser-text">Try again</button> with a file smaller than 10MB.
        </span>
      </span>
      <span class="error empty">
        This file is empty.
        <span class="drag-and-drop-error-info">
          <button type="button" class="btn-link manual-file-chooser-text">Try again</button> with a file that’s not empty.
        </span>
      </span>
      <span class="error hidden-file">
        This file is hidden.
        <span class="drag-and-drop-error-info">
          <button type="button" class="btn-link manual-file-chooser-text">Try again</button> with another file.
        </span>
      </span>
      <span class="error failed-request">
        Something went really wrong, and we can’t process that file.
        <span class="drag-and-drop-error-info">
          <button type="button" class="btn-link manual-file-chooser-text">Try again.</button>
        </span>
      </span>
    </span>
  </p>

      <div class="suggester-container">
        <div class="suggester js-suggester js-navigation-container" data-url="/suggestions/pull_request/243809975?repository=GitHub-Dark&amp;user_id=StylishThemes" hidden="">
        </div>
      </div>
    </div>
</file-attachment>
  <div class="preview-content overflow-auto border-bottom">
    <input type="hidden" name="original-line" value="" class="js-original-line">
    <input type="hidden" name="path" value="" class="js-path">
    <input type="hidden" name="line" value="" class="js-line-number">
    <div class="comment js-suggested-changes-container" data-thread-side="">
  <div class="comment-body markdown-body js-preview-body">
    <p>Nothing to preview</p>
  </div>
</div>

  </div>

  <div class="comment-form-error comment-form-bottom js-comment-update-error"></div>
</div>

    <div class="form-checkbox mx-3 mb-2 mt-0">
      <label class="d-block">
        <input type="radio" name="pull_request_review[event]" value="comment" checked="">
        Comment
        <p class="text-normal text-gray-light">Submit general feedback without explicit approval.</p>
      </label>
    </div>

    <div class="form-checkbox mx-3 my-2">
        <label class="d-block">
        <input type="radio" name="pull_request_review[event]" value="approve">
        Approve
          <p class="text-normal text-gray-light">Submit feedback and approve merging these changes.</p>
      </label>
    </div>

    <div class="form-checkbox mx-3 my-2">
        <label class="d-block">
        <input type="radio" name="pull_request_review[event]" value="reject">
        Request changes
          <p class="text-normal text-gray-light">Submit feedback that must be addressed before merging.</p>
      </label>
    </div>

  <div class="form-actions p-2 m-0 bg-gray-light border-top">
    <button type="submit" class="btn btn-sm btn-primary float-left mr-1" data-disable-with="">
      Submit review
    </button>
    <span class="review-title-with-count text-gray-light float-left mt-1 ml-1">
      <span class="js-pending-review-comment-count">0</span>
      pending
      <span class="js-pending-comment-count-type" data-singular-string="comment" data-plural-string="comments">
        comments
      </span>
    </span>
  </div>
</form>
      </div>
    </details>
</div>

            </div>

                <div class="js-socket-channel js-updatable-content js-pull-refresh-on-pjax" data-channel="pull_request:243809975" data-url="/StylishThemes/GitHub-Dark/pull/827/show_partial_comparison?base_commit_oid=6c61d52cc041c5b4693164754c6ab6ac716d3ff2&amp;end_commit_oid=3aa34493eeca90e0deb927148244b9cb605b1de6&amp;partial=pull_requests%2Fstale_comparison&amp;start_commit_oid=6c61d52cc041c5b4693164754c6ab6ac716d3ff2" data-gid="MDExOlB1bGxSZXF1ZXN0MjQzODA5OTc1"></div>

              <div class="subset-files-tab js-reset-filters f5" hidden="">
              <a class="stale-files-tab-link" href="/StylishThemes/GitHub-Dark/pull/827/files">
                Clear
              </a>
            </div>

            <div class="modal-backdrop js-touch-events"></div>

          </div>
        </div>
Mottie commented 5 years ago

Oops, my fault. Fix incoming.