StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.66k stars 654 forks source link

Unexpected token #901

Closed 0xh3LL0 closed 5 years ago

0xh3LL0 commented 5 years ago
the-j0k3r commented 5 years ago

Hello @0xh3LL0, and thank you for reaching out with this report. You can safely ignore this, its CSSlint, because the usercss doesnt conform to the way options/variables are done.

Stylelint says error | 5642 | : | 3 | Unknown word

In this case I think its here

https://github.com/StylishThemes/GitHub-Dark/blob/246b26cc35b9db669e56921195e5238fca9a34a9/github-dark.user.css#L5642-L5649

That rule looks unclosed but due to variable and way its implemented all linters complain. Yet nothing is up.

silverwind commented 5 years ago

I think we should clean this error up. Maybe with some CSS variables:

.markdown-format pre, .markdown-body pre, .markdown-format .highlight pre,
.markdown-body .highlight pre, #facebox pre, .blob-expanded, .terminal,
.copyable-terminal, #notebook .input_area, .blob-code-context,
.markdown-format code, .api pre, .api code, .hook-delivery-details pre,
.hook-delivery-container pre, .code-list .file-box {
    background: var(--ghd-code-background, #181818) !important;
    color: var(--ghd-code-color, #ccc) !important;
}

And in the theme:

:root {
  --ghd-code-background: #345;
  --ghd-code-color: #cde;
}

Edit: Updated to use var fallbacks.

the-j0k3r commented 5 years ago

seems that last rule is left open to account for user selections for

/*[[syntax-theme]]*/ 
/*[[syntax-codemirror]]*/ 
/*[[syntax-jupyter]]*/ 

I think its best let a PRO handle that =)

Mottie commented 5 years ago

I'm not claiming to be a pro, but it's been fixed.