StylishThemes / GitHub-Dark

:octocat: Dark GitHub style
https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css
BSD 2-Clause "Simplified" License
9.67k stars 655 forks source link

Issue header not displaying properly #963

Closed ackvf closed 5 years ago

ackvf commented 5 years ago

Stylus disabled image

Stylus enabled image

There are two issues:

image

The sticky header is also white

image


As a quick fix, I added a custom section with this code

/* my own overrides */
.gh-header {
    background-color: transparent !important;
}
.gh-header .gh-header-sticky.js-sticky-offset-scroll {
    height: 1px !important;
}

.gh-header-shadow {
    background: #181818 !important;
}
silverwind commented 5 years ago

Your installed style is likely very out of date, try updating it.

the-j0k3r commented 5 years ago

@ackvf, Thank you for reaching out to us with this issue report.

Immediately visiting the page indicated (with Firefox), theres no visible issues like described that I can see.

Screenshot_2019-07-16 Customizable tabs in text editor Multiple rows display, font size, grouping · Issue #32836 · microsof

I cant see anything either with Chrome, and cause @silverwind replied in meanwhile with same suggestion, maybe try disable any other styles just in case they cause any other issues.

ackvf commented 5 years ago

@silverwind I did try to update it before posting and I forced the update over my custom overrides which brought back the issue.

image

Am I doing something wrong?

the-j0k3r commented 5 years ago

over my custom overrides

Maybe thats the issue, What custom overrides are these you mention?

Maybe try not to add any custom overrides, if you meant style settings then IDK, it works here just fine (without any other CSS). Have you some other style active that maybe causing the issues? If so disable that.

ackvf commented 5 years ago

Thank you for your amazingly fast response rate! :)

the-j0k3r commented 5 years ago

Personally speaking, I cant see the issues you reported in 3 browsers, Firefox 68 64bit Or Chrome 75.0.3770.100 and Vivaldi 2.6

Perhaps you may want to remove any browser profiles that stuck around from old insall or try in another machine to see.

ackvf commented 5 years ago

Allright, this is weird. Well actually not that much. My computer is just a month old, but I synchronized all my extensions and settings so the github dark came automatically. Trying to update it yielded an archived version v1.20.84, which is correct as the style itself points to it, so it thinks it's up to date.

/*! Github Dark v1.20.84 (2018-11-19) */
/*! Repository: https://github.com/StylishThemes/GitHub-Dark    */
/*! Userstyle:  http://userstyles.org/styles/37035              */
/*! License:    https://creativecommons.org/licenses/by-sa/4.0/ */

So I have just installed Chrome Canary to get rid of all profile data (just in case), installed Stylus (as the only extension) then I followed the Repository link above, where I clicked the first link

:octocat: Dark GitHub style https://raw.githubusercontent.com/Sty…

which immediately offered me to Install style and then I got the non-archived most recent version.

Anyway, I immediately see a difference in background which I don't like, so I guess, I will have to stick to the old one... Or can I change the background picture easily?

image

Closing as my style was an old archived one and the issue does not apply to the new one. Thanks for your fast responses anyway. And perhaps, advice me how to change the background.

the-j0k3r commented 5 years ago

The background can be customized in Stylus (this style settings)

Capture

ackvf commented 5 years ago

Allright, now I cannot interact with stylus, lol. I created an issue at google https://support.google.com/chrome/thread/9999253

/edit: I managed to get to stylus manager through settings://extensions

Thank you for all the help. And also, thank you for hinting me that there is also a dark style for Stylus :)

the-j0k3r commented 5 years ago

And also, thank you for hinting me that there is also a dark style for Stylus :)

There is and youre welcome ;), the one in use in screenshot, its called Stylus Deepdark

Also you can force style updates by manually updating via clicking the raw link https://raw.githubusercontent.com/StylishThemes/GitHub-Dark/master/github-dark.user.css That should always display the most current version.

Well IDK what to say about any of your issues except I personally cant duplicate them.

Good luck =)