StylishThemes / StackOverflow-Dark

📚 Dark theme for Stack Overflow & most Stack Exchange network sites
https://github.com/StylishThemes/StackOverflow-Dark/raw/master/stackoverflow-dark.user.css
Other
686 stars 43 forks source link

Syntax theme no longer work #218

Closed ghost closed 4 years ago

ghost commented 4 years ago

image

the-j0k3r commented 4 years ago

Just acknowledging the report, just real life so no time to look at it at the moment.It may take a while to get to this.

A quic look tell me this is now using hljs prefixed classes, we dont have literally any themes with hljs and this undertaking will take a long time to fix, if ever, given my low usage of the sites...

Also if someone contributes a theme they use more often, then it will leave all the others with same issue, so I'll have to consider if syntax themes are worth having at all, its certainly not worth having the majority broken.

That said these new themes could be overriden without any CSS at all, just by overriding the root: values which seem to be only these

--highlight-bg: #1c1b1b;
--highlight-color: #fff;
--highlight-comment: #999;
--highlight-punctuation: #ccc;
--highlight-namespace: #f08d49;
--highlight-attribute: #88aece;
--highlight-literal: #f08d49;
--highlight-symbol: #c59bc1;
--highlight-keyword: #88aece;
--highlight-variable: #b5bd68;
--highlight-addition: var(--green-600);
--highlight-deletion: var(--red-700);

So given this, it would be better to rewrite them, which in any case is no simple undertaking. It would be a better design though.

the-j0k3r commented 4 years ago

OK Ive done something simple with a couple of preset themes and a custom, Will be removing the built into style because the new design is incompatible with the existing.

the-j0k3r commented 4 years ago

Consult the readme for instructions.

Any further themes need to be added in same format, the design works, however SO defines which selectors apply, not the theme, any included selectors are to fix some issues with their design and to be compatible with how SO is currently done.