StylishThemes / StackOverflow-Dark

📚 Dark theme for Stack Overflow & most Stack Exchange network sites
https://github.com/StylishThemes/StackOverflow-Dark/raw/master/stackoverflow-dark.user.css
Other
686 stars 43 forks source link

Newsletter sign-up widget has duplicate header #219

Closed LWChris closed 4 years ago

LWChris commented 4 years ago

image image

<div id="newsletter-ad" class="s-sidebarwidget mb16">
    <div class="s-sidebarwidget--header">
        <svg aria-hidden="true" class="svg-icon iconMail" width="18" height="18" viewBox="0 0 18 18"><path d="M1 6l8 5 8-5V4L9 9 1 4c0-1.1.9-2 2-2h12a2 2 0 012 2v10a2 2 0 01-2 2H3a2 2 0 01-2-2V6z"></path></svg> Love this site?
    </div>
    <div class="s-sidebarwidget--content d-block">

        <p id="newsletter-ad-header">Get the <b>weekly newsletter!</b> In it, you'll get:</p>
        <ul>
            <li>The week's top questions and answers</li>
            <li>Important community announcements</li>
            <li>Questions that need answers</li>
        </ul>
    <div id="newsletter-signup-container" class="ta-center">
        <button id="newsletter-signup" class="s-btn s-btn__filled">Sign up for the digest</button>
    </div>
    <p id="newsletter-preview-container" class="mt8 mb0 ta-center">see an <a href="/digest/preview" id="newsletter-preview">example newsletter</a></p>

    </div>
</div>

Source of duplicate seems to be:

#newsletter-ad::before {
    content: "Love this site?";
    font-size: 18px !important;
}

Source of padding seems to be:

.answer, #newsletter-ad {
    padding: 10px !important;
}
the-j0k3r commented 4 years ago

Is this a style bug or present when not using this style?

LWChris commented 4 years ago

It's a style bug.

When StackOverflow-Dark is disabled:

image

When the style is enabled in its current form:

image

With the style enabled, but modified as suggested in PR #220:

image