StylishThemes / StackOverflow-Dark

📚 Dark theme for Stack Overflow & most Stack Exchange network sites
https://github.com/StylishThemes/StackOverflow-Dark/raw/master/stackoverflow-dark.user.css
Other
686 stars 43 forks source link

visited links in answers are shown dark #234

Closed FranklinYu closed 3 years ago

FranklinYu commented 3 years ago

Possibly affected style from Stack Exchange:

.s-prose a:not(.post-tag):not(.s-tag):not(.badge-tag):not(.s-link__visited):not(.s-btn):not(.s-editor-btn):visited,
.comment-copy a:visited {
  color:var(--theme-link-color-visited)
}

I guess we might need some !important somewhere.

Note: I enabled native dark theme in Stack Overflow, which might affect the value of --theme-link-color-visited.

the-j0k3r commented 3 years ago

Would you try adding to your local install of style --theme-link-color-visited: /*[[visited-color]]*/ !important; over --theme-footer-link-color: **#aaa; in main body[class*="theme-"], body { e.g.

  body[class*="theme-"], body {
    --theme-link-color-visited: /*[[visited-color]]*/ !important;
    --theme-footer-link-color: #aaa;
    ...
    ...
    ...
    ...
}

try with and without !important I would prefer not to use it unless necessary.

Also we dont really support dark mode like you suppose, because we are not using css vars from SO, this style is much much much older than all that, and would need to be re-written which is not likely to happen in this organization with this style. If that happen Ill do own style for this, already started, but much in stackexchange is still not using css vars, so Ide like to wait on that front.

So please for best results use default so light mode together with this style, not dark mode and this style together. I also dont fancy unnecessary work to support something that is partially unknown. See https://github.com/StylishThemes/StackOverflow-Dark/issues/214

Let me know what result is of that new line as here I cannot reproduce your issue as my links remain same color, probably because Im blocking 3rd party cookies.

Thanks.

the-j0k3r commented 3 years ago

also please note.

.s-prose a:not(.post-tag):not(.s-tag):not(.badge-tag):not(.s-link__visited):not(.s-btn):not(.s-editor-btn), .comment-copy a { is not visited color as the exceptions :not indicate :not(.s-link__visited) etc...

At best this would be base-color

  .s-prose a:not(.post-tag):not(.s-tag):not(.badge-tag):not(.s-link__visited):not(.s-btn):not(.s-editor-btn), .comment-copy a {
    color: /*[[base-color]]*/
  }
FranklinYu commented 3 years ago

Hi, sorry for not replying. Yes, base-color works for me. Thank you for fixing it!