search

StylishThemes / Wikipedia-Dark

:mortar_board: Dark Wikipedia
https://github.com/StylishThemes/Wikipedia-Dark/raw/master/wikipedia-dark.user.css
Other
486 stars 31 forks source link

Wiki logo #188

Closed o-r-i-z-u-r-u closed 3 years ago

o-r-i-z-u-r-u commented 3 years ago

Hi I'm new to github and I signed up specifically so I could make this request

Would it be possible to edit the style of the Wikipedia logo (wordmark and tagline) on the main page so that it is visible using Wikipedia Dark?

Thanks for reading, the source elements are as follows:

Wordmark SVG <img class="mw-logo-wordmark" alt="Wikipedia" src="/static/images/mobile/copyright/wikipedia-wordmark-en.svg" width="119" height="18">

Tagline SVG <img class="mw-logo-tagline" alt="The Free Encyclopedia" src="/static/images/mobile/copyright/wikipedia-tagline-en.svg" width="117" height="13">

AfroThundr3007730 commented 3 years ago

Those appear to show up fine when I checked a minute ago. Are you using mobile view, or a MediaWiki skin other than the default Vector skin?

o-r-i-z-u-r-u commented 3 years ago

Hmm nope, I'm browsing regular ol' https://en.wikipedia.org/ as in this screenshot Wikipedia Dark 3.5.8 and default vector skin I wonder what is making the difference?

the-j0k3r commented 3 years ago

Hmm nope, I'm browsing regular ol' https://en.wikipedia.org/

You are using a mobile device browser, because Ive just tested it and it confirms your issue.

This is also obvious because your source images are from mobile view.

Anyway. ill push a fix if @AfroThundr3007730 makes a release.

o-r-i-z-u-r-u commented 3 years ago

It's not a mobile device browser. I had another look and it's browsing in non-legacy Vector mode. This is available for users on the site (possibly as the default, I can't recall) It just happens that they store the SVGs in a mobile directory. Otherwise, if you're not logged in, it displays the logo as a PNG using the legacy style

the-j0k3r commented 3 years ago

I tested with a mobile UA and regular desktop UA, not logged in as I dont care about that functionality and by extension not using any settings for the site, this implies default from my side.

Issue was duplicated with mobile UA.

The CSS used doesnt care about file extensions.

So wait until update goes trough when @AfroThundr3007730 has time to make a release with the fix.

Youre welcome to test the fix if it works for you but rememebr any locally edits to any style trumps styles autoupdates, so youll need to force update manually if you test the fix.

All Im interested now is if it worked or not, my guess is it fixed your issue.