StyraHem / ShellyForHASS

Shelly smart home platform for Home Assistant
MIT License
620 stars 111 forks source link

[BUG] Firmware upgrade switch entity ID reset to default (renaming not permanent) #570

Open bcutter opened 3 years ago

bcutter commented 3 years ago

Environment

Describe the bug

The entity ID (possibly the name too) for the upgrade switch is not permanent when changed. It is reset to a default name once a firmware update is available.

Steps to Reproduce

  1. Enable "Create upgrade switch when Shelly has new firmware"
  2. Wait until firmware is available and upgrade switch is created.
  3. Change entity ID (e. g. "switch.shelly_shplg_s_XXXXXX_firmware_update" to "switch.plug_charging_station_kitchen_fw_update").
  4. Perform firmware upgrade. Switch will disappear (or show up as unavailable entity and disappear once HA Core has been restarted).
  5. Wait for next upgrade to be available and upgrade switch is created, check it's entity ID.

Expected behavior

The entity ID set should be permanent instead of defaulting to the factory name.

Screenshots

image image

Traceback/Error logs

Additional context

bcutter commented 2 years ago

When you scroll through the issues list just for fun, click one you think the title sounds interesting and discover it has been created by yourself: priceless.

Well there’s been a lot of progress here. Sadly. Makes me think about having a closer look at the stock Shelly integration.

bcutter commented 2 years ago

Any estimations? It is a bug, not a feature, right?