search

StyraInc / codemirror-rego

A basic rego mode for CodeMirror and the base key-map that we use in our product.
Apache License 2.0
4 stars 5 forks source link

CodeMirror 6/Monaco Editor support #15

Open bengry opened 1 year ago

bengry commented 1 year ago

Currently, this addon only supports CodeMirror 5, while CM 6 has been around for a while, and drastically changed the API. It allows using legacy languages, but either this addon doesn't support it, or I wasn't able to get it to work 😶.

Supporting CodeMirror 6 would be greatly appreciated, as it's much simpler to use, not to mention more modern in a lot of aspects.

Alternatively (and maybe even better) would be Monaco Editor support, but I'm not sure how big is the difference between them in terms of language support.

anderseknert commented 1 year ago

That would indeed be nice :) It's just not be an urgent upgrade for our purposes, so we haven't gotten to it. If someone would want to take a shot at it, that'd be much appreciated.

bengry commented 1 year ago

That would indeed be nice :) It's just not be an urgent upgrade for our purposes, so we haven't gotten to it. If someone would want to take a shot at it, that'd be much appreciated.

Thanks for the response.

An even better solution would be a rego tokenizer for Monaco Editor 🙃, which we use anyway (much better than CM from our experience). Rego is the last thing holding us from dropping CM completely.

There's a solution for VS Code, but it's not for the standalone Monaco Editor, and also not up-to-par with the CM implementation found in this repo.

anderseknert commented 1 year ago

If I may ask, who are "we"/"us" in this context? 😃

bengry commented 1 year ago

If I may ask, who are "we"/"us" in this context? 😃

Ah, of course. https://wiz.io :)

anderseknert commented 1 year ago

Alright! Good to see you here @bengry 🙂