search

StyraInc / opa-aws-cloudformation-hook

AWS Cloudformation Hook for OPA-powered infrastructure policy enforcement
Apache License 2.0
35 stars 5 forks source link

S3 Block Public Access, examples and Rego #1

Closed peteroneilljr closed 2 years ago

peteroneilljr commented 2 years ago

For the Templates directory, every example has 2 to 5 templates and they aren't interchangeable between examples. It might be confusing to have them all in 1 folder. In the end, we could end up with 50 templates in there.

peteroneilljr commented 2 years ago

Fixed the upper and lower case naming convention

anderseknert commented 2 years ago

Fixed the upper and lower case naming convention

Still looks the same to me. Did you forget to add re-add the files? :)

For the Templates directory, every example has 2 to 5 templates and they aren't interchangeable between examples. It might be confusing to have them all in 1 folder. In the end, we could end up with 50 templates in there.

Right, I did not mean to suggest we couldn't use subdirectories, just that we place them in the existing templates directory.

peteroneilljr commented 2 years ago

Take a look once again, I think I've resolved all of your comments.