search

StyraInc / opa-aws-cloudformation-hook

AWS Cloudformation Hook for OPA-powered infrastructure policy enforcement
Apache License 2.0
35 stars 5 forks source link

added security group hook and examples #5

Closed peteroneilljr closed 2 years ago

peteroneilljr commented 2 years ago

I needed to change the hook to work for security groups. So I created a new one under the original one. Let me know if you have a better idea to organize all of the hooks we will need.

anderseknert commented 2 years ago

Hey :) I don't think we'll want to have the user install more than one hook — they should just be able to click/install the OPA hook and have all their cloudformation resources sent via that hook for validation. Could you elaborate on why you think more than one is needed?

peteroneilljr commented 2 years ago

Should we add every resource type to the same hook? Or do you know if it is possible to add a wild card to accept any resource type?

anderseknert commented 2 years ago

Indeed. Created https://github.com/StyraInc/aws-cloudformation-python/issues/6 to track this.

@kroekle looked into wildcards before, but found them unsupported. I haven’t managed to find anything that suggests they are supported either.

We will approach AWS with some of our thoughts on this. Will just need to compile them first.

peteroneilljr commented 2 years ago

I've removed the new hook and updated the original one. Let me know if everything looks good.