search

Styria-Digital / django-rest-framework-jwt

JSON Web Token Authentication support for Django REST Framework
https://styria-digital.github.io/django-rest-framework-jwt/
MIT License
192 stars 60 forks source link

Use force_str to replace deprecated force_text #46

Closed dominik-bln closed 4 years ago

dominik-bln commented 4 years ago

@fitodic Did you close this on purpose? As far as I can tell this change is not included in the referenced merge

fitodic commented 4 years ago

@fitodic Did you close this on purpose? As far as I can tell this change is not included in the referenced merge

Sorry, I accidentaly referenced this issue in the https://github.com/Styria-Digital/django-rest-framework-jwt/commit/b7296dcf6a8b93ae494974c8ba70b141369a4def. Thanks for calling it out :+1:

fitodic commented 4 years ago

I thought I reopened this PR when posting the last comment :thinking:

Sorry, I'm more accustomed to GitLab than GItHub. Is there anything you have to do on your part to reopen it? Or better yet, could you include these changes in https://github.com/Styria-Digital/django-rest-framework-jwt/pull/45?

dominik-bln commented 4 years ago

Sorry, I'm more accustomed to GitLab than GItHub.

I know the feeling 😄

I'll add this to #45

dominik-bln commented 4 years ago

The changes are in #45 now.

fitodic commented 4 years ago

Terrific :+1: I've reopened https://github.com/Styria-Digital/django-rest-framework-jwt/issues/43 so you can link it in the PR and close it properly.