Closed creyD closed 3 years ago
@creyD Thanks for the PR 🙂 Would you mind adding a changelog and updating the returned status code in the test suite?
@fitodic Sure! Sorry I didn't see the Contributing.md before.
Can you test it for you again? There was one test failing, but i don't think this is because of my changes. test_authentication.py Line 120 for reference.
Can you test it for you again? There was one test failing, but i don't think this is because of my changes. test_authentication.py Line 120 for reference.
If that's the one regarding sets and payload key's, it's already been fixed in #81. The only thing that remains is to pull the master
branch and push the changes 🙂
UPDATE: I see the latest pipeline has passed so I guess that's it.
Thanks for merging this so fast! When will there be a new release?
Thanks for merging this so fast! When will there be a new release?
1.17.3 is available on PyPI 🙂
Thanks!
Quick Feedback: This change was a bit surprising in a patch update because it alters the behaviour of the API, i. e. it is a breaking change. For us it hopefully only broke the tests, but changing the docs or putting this in a major update would have seemed more appropriate.
Agree, it's a breaking change which should have gone in a major version update. Thankfully I read changelogs before updating :)
As I said in #79 I adjusted the status codes to return what is documented.