Styria-Digital / django-rest-framework-jwt

JSON Web Token Authentication support for Django REST Framework
https://styria-digital.github.io/django-rest-framework-jwt/
MIT License
191 stars 57 forks source link

Add to changelog a missing Breaking Change on v1.12.8 #92

Closed luzfcb closed 3 years ago

luzfcb commented 3 years ago

This pr document a missing Breaking Change on v1.12.8.

I was migrating a legacy project from djangorestframework-jwt == 1.11.0 to this one and realized that this change was missing on changelog and also that it is very difficult to verify the difference between djangorestframework-jwt and this package, since apparently git mv was not used during directory refactoring and then the git history of rest_framework_jwt/settings.py was not preserved.

--

Pull-request sponsored by

image

codecov-commenter commented 3 years ago

Codecov Report

Merging #92 (6848343) into master (8e5a737) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files          21       21           
  Lines         588      588           
  Branches       69       69           
=======================================
  Hits          552      552           
  Misses         24       24           
  Partials       12       12           
Flag Coverage Δ
codecov 93.19% <ø> (ø)
dj111 92.53% <ø> (ø)
dj20 92.36% <ø> (ø)
dj21 92.36% <ø> (ø)
dj22 92.36% <ø> (ø)
dj30 93.02% <ø> (ø)
drf310 92.36% <ø> (ø)
drf311 93.02% <ø> (ø)
drf37 92.53% <ø> (ø)
drf38 92.53% <ø> (ø)
drf39 92.53% <ø> (ø)
py27 92.36% <ø> (ø)
py35 92.36% <ø> (ø)
py36 92.36% <ø> (ø)
py37 92.36% <ø> (ø)
py38 92.68% <ø> (ø)
pyjwt1 93.19% <ø> (ø)
pyjwt2 93.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e5a737...6848343. Read the comment docs.

fitodic commented 3 years ago

@luzfcb Thanks for pointing that out 👍🏼