search

Su5eD / GregTech-Experimental

A fully-featured port of GregTech 3 for modern minecraft versions
GNU Lesser General Public License v3.0
21 stars 8 forks source link

[Issue][1.12.2] Compat/Recipe Issue with Nuclear Craft #48

Closed accessdenied0 closed 1 year ago

accessdenied0 commented 1 year ago

Describe the bug

If I try to load MC with IC2Exp and GT-Exp and Nuclearcraft (newest tested versions), the game crashes with some kind of Recipe Error. Log attached.

Which side have you encountered the bug on?

Client

Steps to reproduce

  1. Install MC, newest 1.12.2 Forge
  2. Install IC2 Exp.
  3. Install GT-Exp.
  4. Install Nuclear Craft
  5. Crash by loading up.

Logs

https://github.com/Su5eD/GregTech-Experimental/files/10902191/crash-2023-03-06_20.12.49-client.txt

Additional context

I am not sure if an different mod can interfere here, too... but the Crash only happens if NC is installed.

I have not yet tried to remove the OD from Mushrooms from the code, to avoid this error, but I am also unsure which Item I need to address specifically, since the Mushrooms-Block in their default have no OD, only the Mushrooms.

Crash-Log

In any case, I do thank you for your work on this mod!

Su5eD commented 1 year ago

I've added an error handler for IC2 recipes so that the game doesn't crash should anything go wrong. However, I wasn't able to reproduce the issue myself, so I assume NC isn't the only one in play here with the oredict shenanigans. Either way the fix should be quite universal.

Could you try using this build? Just hit Log in as guest if prompted to log in and it'll start downloading.

accessdenied0 commented 1 year ago

I can imagine that some other mod might also cause this... In this pack there are several mods who have to do with OD in regards of Food, in this case it seem to have something to do with the OD of "plant" on Mushroom... It could be Vanilla Pantry, Pam's Harverstcraft, Vibrant Journey or even a different mod like "Industrial Magic"

I have a few of the mods as tests in this pack to figure out which one I wanna take for my World, but NC and GT-Exp, I would like to keep.

Besides this, the fix works just fine! I am still unsure where it comes from, because I see no recipe of NC interfere with Mushrooms...

I thank you alot for the fast fix!

Su5eD commented 1 year ago

sounds good, pushing the update to CF