search

Su5eD / IC2-Patcher

A tool to modify IndustrialCraft2 using binary patches
The Unlicense
9 stars 4 forks source link

OD & OV Scanner crashes #21

Open Frogger60 opened 1 month ago

Frogger60 commented 1 month ago

Using an OD Scanner or OV Scanner causes the game to crash. When playing multiplayer, it crashes Minecraft back to Launcher, in Singleplayer, it crashes back to main menu.

Step 1: Use an OD Scanner or OV Scanner Step 2: Crash

I have tested both with the Patcher and without on the same world. Only crashes with the Patcher.

latest.log

crash-2024-05-16_15.36.15-client.txt

Kanzaji commented 1 month ago

Hey there, thanks for the report!

I investigated it a little already, trying to narrow down the part of the code where it might be broken. The issue is that I narrowed it down to the base patches (Patches that make the Decompiled IC2 possible to recompile) so... fixing this might take some time >.>

EDIT: The entire issue is that networking classes while sending a list over the network, somehow make a list of elements end up as list of one array with all elements of that list?

xJon commented 2 weeks ago

@Kanzaji Any chance for a new build with the fixes? 👀

Kanzaji commented 2 weeks ago

You are lucky, as I'm starting my vacation tomorrow so I will get to it asap, and the build should hopefully be around this time tomorrow 😄 Didn't had time at all to just port the changes to other supported IC2 versions >.>

xJon commented 2 weeks ago

@Kanzaji Still no new build on CurseForge unfortunately...

Kanzaji commented 2 weeks ago

@Kanzaji Still no new build on CurseForge unfortunately...

Waiting for the reply from the Owner (@Su5eD ) about the changes made ^^" Whenever I get it I will upload the new version to CF as fast as possible >.>