search

SuLab / WikidataIntegrator

A Wikidata Python module integrating the MediaWiki API and the Wikidata SPARQL endpoint
MIT License
244 stars 46 forks source link

Python2 compatibility #64

Closed stuppie closed 5 years ago

stuppie commented 6 years ago

I broke python2 compatibility with this commit. (Apparently python2 doesn't have lru_cache). Unless someone strongly objects, I plan on not fixing this, as it is 2018 and nobody should be using python2 anymore.

stuppie commented 6 years ago

Could be fixed by using https://pypi.org/project/cachetools/ however...

sebotic commented 6 years ago

Well, looking at most large libraries like numpy, pandas, tensorflow, these all have py2.7 compatibility. So I'd assume many people still cling to py2.7 as they have a ton of code they need/want to keep compatibility to.

stuppie commented 6 years ago

Many large libraries (pandas and numpy included) have pledged to stop Py2 development by Jan 2019 ! http://python3statement.org/

andrawaag commented 5 years ago

With WD 0.2.0 WDI requires python 3.6>. Removed the qualifier about Python 2.7 from setup.py in https://github.com/SuLab/WikidataIntegrator/commit/3fa73334d740d8e1db058599d3e9dea76f207f82#diff-2eeaed663bd0d25b7e608891384b7298