item_name doesn't do anything

[stuppie]

item_name isn't really used (its only checked to be not empty), but isn't used to retrieve an item or set its label. Probably confusing to new users and should be removed.

[Samwalton9]

I was stumped for a while today about both this and domain. Checked the code and it seems to do nothing, so agree with removal if it's not used.

[andrawaag]

It actually does more than only checking to be not empty. If it is empty, together with the domain argument a new Wikidata item is issued:

https://github.com/SuLab/WikidataIntegrator/blob/555b1ba1bc6743a95d0149053ec1f8399a37399b/wikidataintegrator/wdi_core.py#L188-L199

I agree that this is confusing and should be removed, but since it creates a new item, this function might be used by WDI users.

[andrawaag]

item_name and domain parameter have been removed with version 0.2.0

[andrawaag]

addressed in:

• https://github.com/SuLab/WikidataIntegrator/commit/69d6a20b349cfad843f55b1e4a2399c1b42fb567
• https://github.com/SuLab/WikidataIntegrator/commit/e5865fdb52e18c0cf1057eced415d6893982e85e
• https://github.com/SuLab/WikidataIntegrator/commit/3fb9c457b48804858af0635c0a78b14fc8242c03
• https://github.com/SuLab/WikidataIntegrator/commit/02ae7467ef05f8d0b52ba466da5a549f1fd317b0
• https://github.com/SuLab/WikidataIntegrator/commit/e9ddd2bfe7ca843fd2643b929e718c3929f89d56
• https://github.com/SuLab/WikidataIntegrator/commit/2a484469b84e3cbd3d009798fe7ec75f416b8a55