search

SuLab / mark2cure

Mark2Cure allows anyone that can read English, regardless of background, to help in the process of biomedical discovery.
https://mark2cure.org/
14 stars 8 forks source link

Cleanup Task specific groupings in the database #27

Open JTFouquier opened 8 years ago

JTFouquier commented 8 years ago

Not a huge deal, but the mismatch between the quest number in the URL and the number shown in the web page is weird. Would be good to get those to match.

12-2-2014 4-28-41 PM.jpg

JTFouquier commented 8 years ago

Yeah.. I'm not sure about this. I agree its weird. However the URL-based interaction form the user side is not really there yet anyway. e.g. if I start plugging in numbers into the page id slot manually the behavior is clearly unintentional. I was doing this and hit a 500 error at one point but am struggling to reproduce it. Now, I can use the URLs to get places I can't through the clicking interface - like back to completed quests. So if I use the url to get back to completed quest, it loads a document as before, but then gives me an alert on submit that there was a problem submitting the request. Nice that it doesn't just 500 out, but also not great experience.

If possible, it might be better to simple hide the URLs in this case such that users would be forced to only use the interface to jump around. Would probably produce less headaches. The alternative is to implement all the appropriate logic such that all of the potentially accessible views made sense to the user or at least routed them back to a logical place like the dashboard.

Original comment by: bgood

x0xMaximus commented 8 years ago

@gtsueng I don't expect this to still be an issue as I recall rebuilding the quest naming index a long time ago. Is this safe to close or have there been more recent discrepancies with the url scheme and the titles that we present in the header section of the pages?

x0xMaximus commented 8 years ago

Some concepts to outline:

Task - the Quest Identification number you see in the URL (task_task.id) Quest Name - the Quest Index in the group (task_task.name)

While this issue addresses a naming inconsistancy, it actually address a larger problem in the DB scheme given the addition of 2 task types: ER Tasks (task_task) should live inside the tasks.entity_recognition application