search

SuLab / scheduled-bots

GeneWiki Scheduled Bots
MIT License
9 stars 15 forks source link

instance of adjustments #13

Closed sebotic closed 7 years ago

stuppie commented 7 years ago

Will get_sub_ontology work if the item is new? It won't yet be in Wikidata yet, and so it won't be able to get the sub_ontology, right?

sebotic commented 7 years ago

If the query in get_sub_ontology returns nothing, the for loop will not be entered and the return value of get_sub_ontology will be None, so it will work as expected as self.sub_ontology will stay None

stuppie commented 7 years ago

But then there will be no "instance of" claim on that item, right?

sebotic commented 7 years ago

for the top-level, there should not be one anyway, but for all other levels there will be one as soon as the sparql endpoint has the sub-ontology item id. At latest at the second bot run, all ontology terms will have the proper instance of subclass.