SuaveIO / suave

Suave is a simple web development F# library providing a lightweight web server and a set of combinators to manipulate route flow and task composition.
https://suave.io
Other
1.32k stars 197 forks source link

Websockets don't work in firefox #706

Closed Zeroto closed 6 years ago

Zeroto commented 6 years ago

Description

It seems that firefox includes keep-alive in the connection header causing Suave to send back a bad request during the websocket handshake

Current behaviour:

Suave sends back a 400 bad request because it requires the connection header to be just Upgrade

Desired behaviour:

Suave ignores the other values in the connection header and processes the connection upgrade

Workaround

manually strip the other values from the connection header before sending the request to the handshake.

ademar commented 6 years ago

Hi @Zeroto I've pushed a new pre-release v2.5.0-beta2 with a fix. Please give it a try. Thanks.

Zeroto commented 6 years ago

Works ok now. Thanks 😄