search

SuaveIO / suave

Suave is a simple web development F# library providing a lightweight web server and a set of combinators to manipulate route flow and task composition.
https://suave.io
Other
1.32k stars 198 forks source link

WebPart for sending streams #765

Closed njlr closed 1 year ago

njlr commented 1 year ago
ademar commented 1 year ago

Hi, thanks for the PR.

I think for the feature to be completed it should correctly handle the case where the length of the stream is unknown. In that case it we should transmit the stream down the pipe using chunked transfer encoding.

If you handle that case and add some unit tests we can merge your work.

Thanks,

njlr commented 1 year ago

Hi, thanks for the PR.

I think for the feature to be completed it should correctly handle the case where the length of the stream is unknown. In that case it we should transmit the stream down the pipe using chunked transfer encoding.

If you handle that case and add some unit tests we can merge your work.

Thanks,

Great!

I have added a chunked variant and also some tests. Please let me know what you think 👍

njlr commented 1 year ago

Hi, I've made some suggestions that I think make sense. Let me know what you think.

I have pushed the suggested changes.

ademar commented 1 year ago

Thank you very much!