Fix image source matcher tests so they actually run correctly

Sub6Resources / flutter_html

A Flutter widget for rendering static html as Flutter widgets (Will render over 80 different html tags!)

https://pub.dev/packages/flutter_html

MIT License

1.8k stars 875 forks source link

Fix image source matcher tests so they actually run correctly #1086

Closed Sub6Resources closed 2 years ago

Sub6Resources commented 2 years ago

Saw that we have failing tests and found a bunch of tests for image source CustomRenderMatchers that were created, but never properly finished. I rewrote them to run the test for the expected behavior.

No library changes, just some new tests so we can have a full set of passing tests on master to set the foundation as we add more comprehensive testing across the board.

Sub6Resources commented 2 years ago

I'm going to go ahead and merge. If there's a poorly written test, we'll work through that. Still plenty of testing left to do.

erickok commented 2 years ago

Ah yes forgot to say I ran the tests yesterday and it's looking good. 👍