Closed Sub6Resources closed 2 years ago
Base: 51.09% // Head: 51.44% // Increases project coverage by +0.35%
:tada:
Coverage data is based on head (
7581ea7
) compared to base (ee9f478
). Patch coverage: 47.96% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This is impressive work work Matthew! I am going to take it for a spin tomorrow.
I have a bunch of experience with golden widget tests so if you like I can help with that.
This is working really well. It's not that it solves all issues we had rioght now (and it doesn't need to) but it's a great foundation. I tested on Android and Web and rendering looks good.
The code is looking good, evn though it's a bit tough to read through all changes. But that's okay, I'd rather have this base with a bug than the spaghetti we had right now sometimes. Good job @Sub6Resources
Going to go ahead and merge this since the most recent changes were pretty trivial, unit tests passed, and my visual tests look the same before and after.
There's a lot going on in this branch but it's time for review.
tldr; Calculating widths/margins/padding/border is hard, so I made a new widget that replaces both ContainerSpan and StyledText. This refactor also caused a good chunk of Style code to need refactoring, so I did so, adding support for
em
,rem
,px
,%
, andauto
values on the margin/width/height properties.Fixes:
issue
auto
width and height is now the default, rather thannull
Enhancements:
em
,rem
,px
,auto
, and%
values to be used. (These extend a new Dimension class that does Unit checking to make sure only valid units are used)em
values now used forh1
-6
andp
tag default margins and font sizes, which are more accurate at various font sizes.Notable breaking change: