Closed Sub6Resources closed 1 year ago
@erickok have you had a chance to look at this PR?
To be honest, since we're still trying to get a 3.0 ready, breaking the API big time, I'd get rid of the limited SelectableHtml entirely. Deprecations are nice in minor releases and are developer friendly, but we have a clean, superior and 'free' alternative.
That works for me! I'll get this updated sometime today
Base: 51.40% // Head: 51.07% // Decreases project coverage by -0.32%
:warning:
Coverage data is based on head (
b067c71
) compared to base (c75e0df
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@erickok. It's all removed!
As I've been (finally) working at the migration from customRender
to Extension
, I ended up touching a lot of the same code as this pull request. As such, I decided to just include all the changes from this PR into the other branch manually rather than resolving massive merge conflicts after the fact. That said, I'm going to close this PR, with the changes continuing on into #1176. I'll push the changes to that PR in a few hours.
This should resolve a few issues regarding the
SelectableHtml
/Html
feature parity. Users can achieve a much cleaner result by using aSelectionArea
widget to wrapHtml
.Fixes #1137 Closes #717 Closes #1134 Closes #1105