Closed Sub6Resources closed 1 year ago
Base: 49.70% // Head: 51.41% // Increases project coverage by +1.71%
:tada:
Coverage data is based on head (
91a7e70
) compared to base (cb23cf0
). Patch coverage: 79.05% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@erickok If you wouldn't mind doing a quick rereview on the most recent commit (which re-adds basic list-style-image
support), that would be great. I also cleaned a few things up so there isn't as much repeated code.
The new
CssBoxWidget
allows us to effectively render a "marker box" on elements, especially list elements. This upgrade fixes almost all of our open list issues. It removes support for custom Widget list markers, since CSS doesn't support that (however, the same functionality could easily be re-added in aCustomRender
by interested parties).This pull request also removes the roman-numeral-specific
numerus
dependency in favor of the more generallist_counter
dependency (disclosure: package written by myself). This change in dependency allows us to expand our list style support to 54 different list-styles, including dozens of new languages.This pull request fixes the following open and tightly-related issues:
Fixes #1100
Fixes #245
Fixes #984
Fixes #991
Fixes #1016
Fixes #1020
Fixes #1104
This pull request is
a work in progressready to go. Still to do: