Closed Sub6Resources closed 1 year ago
Patch coverage: 77.09
% and project coverage change: +5.76
:tada:
Comparison is base (
c75e0df
) 51.40% compared to head (3ed46cf
) 57.16%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @Sub6Resources - is there anything the community can do to help get this PR finished and a new major version released?
Continuing from #1153
Migrating to Extension
has touched pretty much all of the codebase, so I've taken the opportunity to remove some technical debt and fix bugs as I found them.
Here's a summary of major changes in this PR so far (this list is a work in progress):
SelectableHtml
(users should now use SelectionArea
provided by Flutter). See #1153. Fixes #1137 <table>
code. Fixes #1199 <img>
code. Removes default loading animation. (fixes #1180)This pull request is ready. Just needs some additional documentation on the Wiki. Anybody that's just stopping in, please review! I'd love to get this release out sometime tomorrow!
There was a comment made on the initial extension api RFC issue about the name of the api, with Extension
potentially being confusing and leading to conflicts with it being quite generic. A suggestion was made to change to something like HtmlExtension
. I was wondering if you had any thoughts on this.
re: https://github.com/Sub6Resources/flutter_html/issues/1142#issuecomment-1333679864
@PritamSangani Thanks for pointing that out. I had forgotten about that comment (although I had named all the extension packages as if I had already made the change -- IframeHtmlExtension
for example).
I agree! Just updated from Extension
to HtmlExtension
congrats 🥳
Closes #1142
Getting started on this. Here's a task list for myself. Any additional feedback/suggestions are still welcome.
HtmlExtension
classExtensionContext
classHtmlExtension
into theHtml
widget flowTagExtension
helper classMatcherExtension
helper classHtmlExtension
HtmlExtension
HtmlExtension
HtmlExtension
HtmlExtension
HtmlExtension
ImageExtension
classHtmlExtension
Fixes #1137 Closes #717 Closes #1134 Closes #1105
Fixes #1206. Fixes #1199. Fixes #1180. Fixes #1113