To repro with #1037, the style section can be commented out.
Expected behavior:
CSS border style shouldn't be inherited, so text spans shouldn't receive their own borders.
Screenshots:
At master:
With the patch to only apply inherited styles to cell children:
What the table in #1037 looks like at master:
With patch:
Device details and Flutter/Dart/flutter_html versions:
Flutter 3.6.0-1.0.pre.3
Dart SDK version: 2.19.0-377.0.dev
flutter_html: ^3.0.0-alpha.6
flutter_html_table: ^3.0.0-alpha.4
Additional info:
Let me know if you want a pull request for this line, though guidance towards finding/adding a pertinent test would be appreciated. Totally understand if there's a better way to fix this though.
A picture of a cute animal (not mandatory but encouraged)
Describe the bug:
Borders on table cells are unexpectedly inherited by underlying text. I suspect this is a regression as #1037 shows borders rendering as expected. I did not find a workaround by playing with
styles
, but this seems correctable by changing https://github.com/Sub6Resources/flutter_html/blob/c75e0dfb1be6cb79748f719487043d12bc330c60/packages/flutter_html_table/lib/flutter_html_table.dart#L120 to only apply the inherited styles to the child:HTML to reproduce the issue:
This repros with the table provided in #1037 and also with the following HTML (abridged for brevity).
Html
widget configuration:To repro with #1037, the
style
section can be commented out.Expected behavior:
CSS border style shouldn't be inherited, so text spans shouldn't receive their own borders.
Screenshots:
At
master
:With the patch to only apply inherited styles to cell children:
What the table in #1037 looks like at
master
:With patch:
Device details and Flutter/Dart/
flutter_html
versions:Additional info: Let me know if you want a pull request for this line, though guidance towards finding/adding a pertinent test would be appreciated. Totally understand if there's a better way to fix this though.
A picture of a cute animal (not mandatory but encouraged)