Sub6Resources / flutter_html

A Flutter widget for rendering static html as Flutter widgets (Will render over 80 different html tags!)
https://pub.dev/packages/flutter_html
MIT License
1.79k stars 860 forks source link

[BUG] Accessibility and scaling #1211

Closed theSharpestTool closed 1 year ago

theSharpestTool commented 1 year ago

Issue #308 occurs again in 3.0.0-alpha.6. While in 3.0.0-alpha.5 text scaling works fine.

To reproduce set the text size to large in the device settings and check the following code:

import 'package:flutter/material.dart';
import 'package:flutter_html/flutter_html.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    const heading2Style = TextStyle(
      fontSize: 24,
      fontWeight: FontWeight.bold,
    );

    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(),
        body: SingleChildScrollView(
          child: Column(
            crossAxisAlignment: CrossAxisAlignment.start,
            children: [
              const Padding(
                padding: EdgeInsets.only(left: 8),
                child: Text(
                  'Heading2',
                  style: heading2Style,
                ),
              ),
              Html(
                data: '<h2>Heading2</h2>',
                style: {
                  'h2': Style.fromTextStyle(heading2Style),
                },
              ),
            ],
          ),
        ),
      ),
    );
  }
}

3.0.0-alpha.5

Simulator Screen Shot - iPhone 14 Pro Max - 2022-12-28 at 19 18 36

3.0.0-alpha.6

Simulator Screen Shot - iPhone 14 Pro Max - 2022-12-28 at 19 23 58

esconts commented 1 year ago

+1

martijnvanderlaan commented 1 year ago

+1

lflorent commented 1 year ago

+1 I confirm this issue with 3.0.0 alpha 6.

lflorent commented 1 year ago

I discover that there is a fix on master branch not available on last alpha.8 release.

This fix works for me.

@Sub6Resources maybe you can merge your fix in next alpha release ? Thanks

daveshirman commented 1 year ago

For anyone struggling with this as of today (02/02/2023) - I added this repo to my dependency_overrides in pubspec.yaml:

dependency_overrides:
  flutter_html:
    git:
      url: https://github.com/Sub6Resources/flutter_html  

I would note that it's not a 100% fix, because now the html text doesn't respect (grow or shrink) the system accessibility scaling at all.

TNelen commented 1 year ago

+1

iamriajul commented 1 year ago

+1

ara-mentz commented 1 year ago

+1

Sub6Resources commented 1 year ago

Able to reproduce on current master branch. Looking into it!

Sub6Resources commented 1 year ago

Fixed in #1259. Changes should be published in 3.0.0-beta.2 by the end of the week.