search

Sub6Resources / flutter_html

A Flutter widget for rendering static html as Flutter widgets (Will render over 80 different html tags!)
https://pub.dev/packages/flutter_html
MIT License
1.79k stars 860 forks source link

fix: Cleaned up whitespace processing and added whitespace tests #1267

Closed Sub6Resources closed 1 year ago

Sub6Resources commented 1 year ago

Fixes #1146 and fixes #1251

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 87.27% and project coverage change: +0.42 :tada:

Comparison is base (fe896de) 59.31% compared to head (46fb455) 59.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1267 +/- ## ========================================== + Coverage 59.31% 59.73% +0.42% ========================================== Files 37 37 Lines 2652 2690 +38 ========================================== + Hits 1573 1607 +34 - Misses 1079 1083 +4 ``` | [Impacted Files](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker) | Coverage Δ | | |---|---|---| | [lib/src/builtins/styled\_element\_builtin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9idWlsdGlucy9zdHlsZWRfZWxlbWVudF9idWlsdGluLmRhcnQ=) | `92.51% <37.50%> (-4.30%)` | :arrow_down: | | [lib/src/processing/whitespace.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9wcm9jZXNzaW5nL3doaXRlc3BhY2UuZGFydA==) | `85.47% <95.12%> (+0.58%)` | :arrow_up: | | [lib/src/builtins/text\_builtin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9idWlsdGlucy90ZXh0X2J1aWx0aW4uZGFydA==) | `96.15% <100.00%> (+0.32%)` | :arrow_up: | | [lib/src/tree/replaced\_element.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy90cmVlL3JlcGxhY2VkX2VsZW1lbnQuZGFydA==) | `63.15% <100.00%> (+4.33%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1267/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.