search

Sub6Resources / flutter_html

A Flutter widget for rendering static html as Flutter widgets (Will render over 80 different html tags!)
https://pub.dev/packages/flutter_html
MIT License
1.79k stars 860 forks source link

feat: Update CssBoxWidget to handle rtl marker boxes #1270

Closed Sub6Resources closed 1 year ago

Sub6Resources commented 1 year ago

This involved adding more options to the Margins class, as well as refactoring the padding option to take a new HtmlPaddings object.

Fixes #1257

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 73.68% and project coverage change: +4.09 :tada:

Comparison is base (496d1aa) 60.02% compared to head (103ce62) 64.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1270 +/- ## ========================================== + Coverage 60.02% 64.11% +4.09% ========================================== Files 37 38 +1 Lines 2699 2979 +280 ========================================== + Hits 1620 1910 +290 + Misses 1079 1069 -10 ``` | [Impacted Files](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker) | Coverage Δ | | |---|---|---| | [lib/src/style/padding.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9zdHlsZS9wYWRkaW5nLmRhcnQ=) | `51.02% <51.02%> (ø)` | | | [lib/src/style/margin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9zdHlsZS9tYXJnaW4uZGFydA==) | `64.00% <61.44%> (-19.79%)` | :arrow_down: | | [lib/src/style.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9zdHlsZS5kYXJ0) | `85.64% <76.92%> (+0.84%)` | :arrow_up: | | [lib/src/css\_parser.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9jc3NfcGFyc2VyLmRhcnQ=) | `35.92% <89.92%> (+18.44%)` | :arrow_up: | | [lib/src/css\_box\_widget.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9jc3NfYm94X3dpZGdldC5kYXJ0) | `64.95% <91.30%> (+0.61%)` | :arrow_up: | | [lib/src/processing/margins.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9wcm9jZXNzaW5nL21hcmdpbnMuZGFydA==) | `93.87% <92.85%> (+0.85%)` | :arrow_up: | | [lib/src/builtins/styled\_element\_builtin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9idWlsdGlucy9zdHlsZWRfZWxlbWVudF9idWlsdGluLmRhcnQ=) | `92.42% <100.00%> (+0.20%)` | :arrow_up: | | [lib/src/style/length.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9zdHlsZS9sZW5ndGguZGFydA==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.