search

Sub6Resources / flutter_html

A Flutter widget for rendering static html as Flutter widgets (Will render over 80 different html tags!)
https://pub.dev/packages/flutter_html
MIT License
1.79k stars 860 forks source link

fix: improve API for ExtensionContext and export marker.dart #1273

Closed Sub6Resources closed 1 year ago

Sub6Resources commented 1 year ago

Fixes #1272 Fixes #1252

This simplifies the API for classes extending HtmlExtension by moving information about children to the ExtensionContext.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 72.41% and project coverage change: +0.18 :tada:

Comparison is base (15cb05e) 59.85% compared to head (9fde184) 60.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1273 +/- ## ========================================== + Coverage 59.85% 60.04% +0.18% ========================================== Files 37 37 Lines 2698 2698 ========================================== + Hits 1615 1620 +5 + Misses 1083 1078 -5 ``` | [Impacted Files](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker) | Coverage Δ | | |---|---|---| | [lib/src/builtins/details\_element\_builtin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9idWlsdGlucy9kZXRhaWxzX2VsZW1lbnRfYnVpbHRpbi5kYXJ0) | `11.11% <0.00%> (ø)` | | | [lib/src/builtins/image\_builtin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9idWlsdGlucy9pbWFnZV9idWlsdGluLmRhcnQ=) | `60.39% <ø> (ø)` | | | [lib/src/builtins/ruby\_builtin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9idWlsdGlucy9ydWJ5X2J1aWx0aW4uZGFydA==) | `92.06% <ø> (ø)` | | | [lib/src/builtins/text\_builtin.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9idWlsdGlucy90ZXh0X2J1aWx0aW4uZGFydA==) | `96.15% <ø> (ø)` | | | [lib/src/extension/helpers/image\_extension.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9leHRlbnNpb24vaGVscGVycy9pbWFnZV9leHRlbnNpb24uZGFydA==) | `0.00% <0.00%> (ø)` | | | [lib/src/extension/helpers/image\_tap\_extension.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9leHRlbnNpb24vaGVscGVycy9pbWFnZV90YXBfZXh0ZW5zaW9uLmRhcnQ=) | `0.00% <0.00%> (ø)` | | | [lib/src/extension/helpers/matcher\_extension.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9leHRlbnNpb24vaGVscGVycy9tYXRjaGVyX2V4dGVuc2lvbi5kYXJ0) | `53.84% <ø> (ø)` | | | [lib/src/extension/helpers/tag\_extension.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9leHRlbnNpb24vaGVscGVycy90YWdfZXh0ZW5zaW9uLmRhcnQ=) | `66.66% <ø> (ø)` | | | [lib/src/extension/html\_extension.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9leHRlbnNpb24vaHRtbF9leHRlbnNpb24uZGFydA==) | `81.25% <0.00%> (ø)` | | | [lib/src/processing/lists.dart](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker#diff-bGliL3NyYy9wcm9jZXNzaW5nL2xpc3RzLmRhcnQ=) | `90.90% <ø> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/Sub6Resources/flutter_html/pull/1273?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Matthew+Whitaker) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.