Sub6Resources / flutter_html

A Flutter widget for rendering static html as Flutter widgets (Will render over 80 different html tags!)
https://pub.dev/packages/flutter_html
MIT License
1.79k stars 860 forks source link

[BUG] Unnecessary line break in <ul> / <ol> #1295

Closed dargoz closed 1 year ago

dargoz commented 1 year ago

Describe the bug:

When I create multiline of ordered list, it rendered with empty line like this : image

when I tried to open the plain html in browser it rendered as expected : image

HTML to reproduce the issue:


<h1 id="1914-translation-by-h-rackham-2">1914 translation by H. Rackham</h1>
<p>"But I must explain to you how all this mistaken idea of denouncing pleasure and praising pain was born and I will give you a complete account of the system, and expound the actual teachings of the great explorer of the truth, the master-builder of human happiness. No one rejects, dislikes, or avoids pleasure itself, because it is pleasure, but because those who do not know how to pursue pleasure rationally encounter consequences that are extremely painful. Nor again is there anyone who loves or pursues or desires to obtain pain of itself, because it is pain, but because occasionally circumstances occur in which toil and pain can procure him some great pleasure. To take a trivial example, which of us ever undertakes laborious physical exercise, except to obtain some advantage from it? But who has any right to find fault with a man who chooses to enjoy a pleasure that has no annoying consequences, or one who avoids a pain that produces no resultant pleasure?"</p>
<ul>
    <li>test bullet 1</li>
    <li>test bullet 2</li>
    <li>test bullet 3</li>
</ul>
<ol>
    <li>
        <p>test numeric list</p>
        <p>asdadadad</p>
    </li>
    <li>
        <p>asdf ghjkl</p>
        <p>asdasdasd</p>
    </li>
    <li>
        <p>asdas</p>
    </li>
    <li>
        <p>sample number 4</p>
    </li>
</ol>

Html widget configuration:

I use default configuration with <li>, <ul> and <ol> (no custom render) Expected behavior:

image Screenshots:

Device details and Flutter/Dart/flutter_html versions:

flutter_html : 3.0.0-beta1

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.7.0, on Microsoft Windows [Version 10.0.22621.1702], locale en-ID)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.5.0)
[!] Android Studio (version 2022.2)
    X Unable to find bundled Java version.
[√] IntelliJ IDEA Community Edition (version 2023.1)
[√] VS Code (version 1.76.1)
[√] Connected device (3 available)
[√] HTTP Host Availability

Stacktrace/Logcat

not applicable Additional info:

A picture of a cute animal (not mandatory but encouraged)

Sub6Resources commented 1 year ago

This has been fixed in the latest 3.0.0-beta.2. Please let me know if you continue to see the issue